From d976280f6166d75fc5c191da37204bdda2882e14 Mon Sep 17 00:00:00 2001 From: "cgero.eth" Date: Wed, 13 Mar 2024 12:16:18 +0100 Subject: [PATCH] fix: Correctly mark peer-dependencies as external dependencies, disable export of module components (#125) --- CHANGELOG.md | 5 +++++ rollup.config.js | 2 +- src/index.ts | 5 ++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6914cc2b5..fc15ce906 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## [Unreleased] +### Fixed + +- Fix library build to avoid bundling peer dependencies +- Remove export of module components until the Aragon App migrates to Wagmi v2 + ## [1.0.19] - 2024-03-13 ### Added diff --git a/rollup.config.js b/rollup.config.js index a07028770..662d2b808 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -36,7 +36,7 @@ module.exports = [ plugins: [analyze ? visualizer({ filename: 'stats.cjs.html', open: true }) : undefined], }, ], - external: Object.keys(package.dependencies), + external: [...Object.keys(package.dependencies), ...Object.keys(package.peerDependencies)], plugins: [ // Locate and resolve node modules nodeResolve(), diff --git a/src/index.ts b/src/index.ts index 01d5ed10a..5d24c5c30 100644 --- a/src/index.ts +++ b/src/index.ts @@ -1,2 +1,5 @@ export * from './core'; -export * from './modules'; +// Temporarily disable modules component export as Aragon App will throw error when trying to import components from +// the ODS library. The error is caused by the ODS build because it imports the WagmiProvider that is not implemented +// on Wagmi v1. Enable modules component export when Aragon App migrates to Wagmi v2 (https://aragonassociation.atlassian.net/browse/APP-2949) +// export * from './modules';