diff --git a/modules/client/CHANGELOG.md b/modules/client/CHANGELOG.md index 7afc84677..3860530d3 100644 --- a/modules/client/CHANGELOG.md +++ b/modules/client/CHANGELOG.md @@ -18,6 +18,10 @@ TEMPLATE: --> ## [UPCOMING] +### Fixed +- Compare with dao address in `validatePluginUpdateProposal` + +## [1.21.1] ### Changed - Chore: Changed voters and approvers count to 1000 from the default value of 100 in Proposal Queries diff --git a/modules/client/package.json b/modules/client/package.json index e7bc84793..bd861568f 100644 --- a/modules/client/package.json +++ b/modules/client/package.json @@ -1,7 +1,7 @@ { "name": "@aragon/sdk-client", "author": "Aragon Association", - "version": "1.21.1", + "version": "1.21.2", "license": "MIT", "main": "dist/index.js", "module": "dist/sdk-client.esm.js", diff --git a/modules/client/src/internal/utils.ts b/modules/client/src/internal/utils.ts index 1fcd42fab..c5ec06bb3 100644 --- a/modules/client/src/internal/utils.ts +++ b/modules/client/src/internal/utils.ts @@ -1033,13 +1033,16 @@ export function validateGrantRootPermissionAction( ); } // The action should be sent to the DAO + // both come from subgraph so they are already lowercase if (action.to !== daoAddress) { causes.push( PluginUpdateProposalInValidityCause .INVALID_GRANT_ROOT_PERMISSION_TO_ADDRESS, ); } - if (decodedPermission.where !== daoAddress) { + // decodedPermission.where is checksummed so we need to lowercase it + // to compare it with the daoAddress because it comes from the subgraph + if (decodedPermission.where.toLowerCase() !== daoAddress) { causes.push( PluginUpdateProposalInValidityCause .INVALID_GRANT_ROOT_PERMISSION_WHERE_ADDRESS,