Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide AbstractModel into ProbabilisticModel and ManifoldModel #85

Open
NicolasGensollen opened this issue Jul 27, 2023 · 1 comment
Open

Comments

@NicolasGensollen
Copy link
Member

In GitLab by @JulietteOrtholand on Jul 27, 2023, 13:42

I was thinking about how to integrate a pure survival model into the model structure and I just can't. I describe in the structure below extracted from refacto notes, the existing AbstractModel should be divided at least in 2 (maybe in the long run in 3): a ProbabilisticModel and a ManifoldModel.

Capture_d_écran_2023-07-27_à_13.38.25

Indeed, time_reparametrization is defined in AbstractModel and has no sense for a pure survival model... It should not have an impact on joint model development for now as the survival part of the joint model can not exist on it own.

@NicolasGensollen
Copy link
Member Author

In GitLab by @JulietteOrtholand on Feb 17, 2025, 18:23

@NicolasGensollen I have made a first draft on the structure of the models here, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant