Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ruleset causes groups.google.com to show blank pages in Firefox #18

Open
dgonyier opened this issue Oct 12, 2015 · 4 comments
Open

Comments

@dgonyier
Copy link

I narrowed the issue down in the default ruleset. Commenting out the injected function line below allows groups.google.com pages to work again

[Inject]
function='DM_tag'
function='OA_show' 
#function='_gat._getTracker'
function='quantserve'
function='s.t'
function='setOmniturePageName'
function='urchinTracker'

Not sure when this issue started but I am seeing it in Firefox 41.0.1. It might have been an issue for quite a while.

@arantius
Copy link
Owner

Confirmed. This is probably broken as either part of the recent e10s compatibility update, or related Firefox changes; the objects that get injected aren't as accessible to content as they once were.

@arantius
Copy link
Owner

This beta version should help. Confirmation would be very nice.

https://addons.mozilla.org/firefox/downloads/file/384782/karma_blocker-0.6.2beta2-fx.xpi?src=devhub

@jawz101
Copy link

jawz101 commented Jan 12, 2016

Doesn't work for me unless I toggle KarmaBlocker off and back on. 0.6.2beta2
or if I delete the rule in the OP it works as well

@arantius
Copy link
Owner

I looked at the problem, saw the failure, simulated it to make it easier/faster to test and fix. Then pushed the above beta. Turns out I only fixed the first issue, and for the real site there's more.

@arantius arantius reopened this Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants