Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No.214]Bug in nwb file saved as a result of suite2p edit roi #511

Closed
itutu-tienday opened this issue Dec 16, 2024 · 7 comments · Fixed by #587
Closed

[No.214]Bug in nwb file saved as a result of suite2p edit roi #511

itutu-tienday opened this issue Dec 16, 2024 · 7 comments · Fixed by #587
Assignees
@tsuchiyama-araya
Milestone
ver2.0

Comments

@itutu-tienday
Copy link
Collaborator

requirement

note

  • Could the following modifications be related?
@tsuchiyama-araya
Copy link
Collaborator

内容確認のSlack
https://araya.slack.com/archives/C04J51TUWJW/p1737431832113729

@tsuchiyama-araya
Copy link
Collaborator

今回のバグ再現
発生している箇所は、ROIをDeleteする際に発生しています。

Image

@tsuchiyama-araya
Copy link
Collaborator

studio/app/optinist/core/edit_ROI/edit_ROI.py <- 177行目でROI Deleteの処理動いています。

@tsuchiyama-araya
Copy link
Collaborator

こちらの対応では、解消できませんでした。
9695fde

@tsuchiyama-araya
Copy link
Collaborator

CaimanとLccdのROIには発生していません。

@tsuchiyama-araya
Copy link
Collaborator

Edit RoiのMergeの時にも発生しています。

@itutu-tienday itutu-tienday added this to the ver2.0 milestone Jan 28, 2025
@tsuchiyama-araya tsuchiyama-araya linked a pull request Feb 5, 2025 that will close this issue
Suite2pをEdit Roiした際にFluoresenceのダイメンションが逆になっている問題対応 #587
Merged
@tsuchiyama-araya
Copy link
Collaborator

テストケース
https://docs.google.com/spreadsheets/d/1GyP-iPyNeye_HO0dKoi5JfOOBTIQnP7WPbWXhl_GtqQ/edit?pli=1&gid=1490640516#gid=1490640516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuchiyama-araya tsuchiyama-araya

Labels
None yet
Projects
None yet
Milestone
ver2.0
2 participants
@itutu-tienday @tsuchiyama-araya