Add Node of rou_fluo_from_hdf5 #575
Open
+85
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
データの追加方法 Screen.Recording.2025-01-30.at.16.59.19.mov |
itutu-tienday
requested changes
Feb 4, 2025
| .filter((itemId) => { | ||
| const item = selectVisualizeItemById(itemId)(state) | ||
| return ( | ||
| (isImageItem(item) && !item.isWorkflowDialog) || |
There was a problem hiding this comment.
細かい指摘ですが、この部分はrefactorできそうです。（!item.isWorkflowDialog の複数回判定が冗長）
|
|
||
| # Enrich output with metadata and processed data | ||
| output = { | ||
| "iscell": IscellData(iscell_data, file_name="iscell") if iscell else None, |
There was a problem hiding this comment.
if iscell else None の判定を複数回実施しているが、これは適切であるか？（冗長な処理、またはチェックすべき変数が適切ではないのでは？）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
要件
ROI（領域）とFluorescence（蛍光データ）を同時に保持・確認できる仕組みを構築すること。
現状では、roi_from_hdf5 と fluo_from_hdf5 が別々に管理されており、同一データかどうかを確認することが困難な状況になっています。
対応内容
今後、HDF5内のROIとFluorescenceデータを連携して扱えるようにするため、これらを1つのノードで保持できる仕組みを作成しました。
このノードを利用することで、ROIとFluorescenceのデータを同時に管理・確認でき、データの連携が容易になります。
具体的な変更点:
ROIとFluorescenceの統合
連携対応
テストケース
https://docs.google.com/spreadsheets/d/1SXsn26sk67WvEVq4B3XGRTxK8mVkLPwpTNC9nz6bFnQ/edit?gid=1902535314#gid=1902535314