Allow waiting for starting complete #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did this by creating an output for starting
mfleader
approved these changes
Nov 6, 2023
dustinblack
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set this to a draft because I'd like feedback before merging.
This is possible by creating an output for starting.
I'm open to suggestions for the naming of the output. Technically speaking started is completed just before instructing the ATP server to start the step. So technically it's not started. But practically speaking, it is.
I have it set to
started, which results in the node$.steps.nameofstep.starting.started.Other possible output names include "complete", "done", and "finished", resulting in something like
$.steps.nameofstep.starting.completeI'm also open to feedback on if you want to pursue an alternative way of enabling this functionality.
By contributing to this repository, I agree to the contribution guidelines.