Fix load context bug #137
Merged
Fix load context bug #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
reviewed
Jan 4, 2024
jaredoconnell
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Something broke:
joconnel@joconnel-mac arcaflow-engine % export WFPATH=/Users/joconnel/Documents/projects/arcaflow/workflows/test-workflows/python_deployer_wait_simple
joconnel@joconnel-mac arcaflow-engine % go run cmd/arcaflow/main.go -config=$WFPATH/config.yaml -input=$WFPATH/input.yaml -context=$WFPATH
2024-01-04T15:45:44-05:00 error source=main Failed to load configuration file /Users/joconnel/Documents/projects/arcaflow/workflows/test-workflows/python_deployer_wait_simple/config.yaml (error loading context files, failed to read file /Users/joconnel/Documents/projects/arcaflow-clean/arcaflow-engine (read /Users/joconnel/Documents/projects/arcaflow-clean/arcaflow-engine: is a directory))
We've allowed specifying the entire directory, which, from that, it determined the workflow path without it being explicitly set. That appears to be broken now.
|
I initialized the slice to an incorrect length which added several empty strings that were converted to absolute file paths. It seems to be fixed now. |
jaredoconnell
approved these changes
Jan 4, 2024
webbnh
reviewed
Jan 4, 2024
dbutenhof
reviewed
Jan 5, 2024
mfleader
force-pushed
the
bug-load-context
branch
2 times, most recently
from
00da437
to
c2acab8
Compare
add readable test refactor to load context test changes fix linting add test explanation refactor to limit context files read change context establishment
rewrite test and add comment fix init slice len fix gosec warning maybe report abs file path config use abs filepath use regular file move code clarify test simplify error msg func comment
mfleader
force-pushed
the
bug-load-context
branch
from
c2acab8
to
4e23bfd
Compare
webbnh
approved these changes
Jan 5, 2024
dbutenhof
approved these changes
Jan 5, 2024
dbutenhof
approved these changes
Jan 5, 2024
dbutenhof
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
By contributing to this repository, I agree to the contribution guidelines.