-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support Node16 ESM resolution (#140)
* add e2e test for CommonJS/ESM * Make it compatible with ESM on NodeJS * fix module resolution on project * fix a test case * update eslint packages
- Loading branch information
Showing
8 changed files
with
1,381 additions
and
420 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,6 @@ export default { | |
| }), | ||
| ts({ | ||
| tsconfig: `tsconfig.dist.json`, | ||
| include: `./sources/**/*`, | ||
| }), | ||
| ], | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| import {execUtils} from '@yarnpkg/core'; | ||
| import {xfs, PortablePath, npath} from '@yarnpkg/fslib'; | ||
|
|
||
| describe(`E2E`, () => { | ||
| it(`works with CommonJS`, async () => { | ||
| await xfs.mktempPromise(async tempDir => { | ||
| const rndName = Math.floor(Math.random() * 100000000).toString(16).padStart(8, `0`); | ||
|
|
||
| const packed = await execUtils.execvp(`yarn`, [`pack`, `--out`, npath.fromPortablePath(`${tempDir}/${rndName}.tgz`)], { | ||
| cwd: npath.toPortablePath(__dirname), | ||
| }); | ||
| expect(packed.code).toEqual(0); | ||
|
|
||
| await xfs.writeJsonPromise(`${tempDir}/package.json` as PortablePath, {name: `test-commonjs`}); | ||
| await xfs.writeFilePromise(`${tempDir}/yarn.lock` as PortablePath, ``); | ||
|
|
||
| const added = await execUtils.execvp(`yarn`, [`add`, `./${rndName}.tgz`], {cwd: tempDir}); | ||
| expect(added.code).toEqual(0); | ||
|
|
||
| await xfs.writeFilePromise(`${tempDir}/index.cjs` as PortablePath, | ||
| `const {Command, Option, runExit} = require('clipanion'); | ||
| runExit(class MainCommand extends Command { | ||
| name = Option.String(); | ||
| async execute() { | ||
| this.context.stdout.write(\`Hello \${this.name}!\\n\`); | ||
| } | ||
| })`, | ||
| ); | ||
|
|
||
| const result = await execUtils.execvp(`node`, [`${tempDir}/index.cjs`, `World`], {cwd: tempDir}); | ||
| expect(result).toEqual({ | ||
| code: 0, | ||
| stderr: ``, | ||
| stdout: `Hello World!\n`, | ||
| }); | ||
| }); | ||
| }, 20000); | ||
|
|
||
| it(`works with ESM`, async () => { | ||
| await xfs.mktempPromise(async tempDir => { | ||
| const rndName = Math.floor(Math.random() * 100000000).toString(16).padStart(8, `0`); | ||
|
|
||
| const packed = await execUtils.execvp(`yarn`, [`pack`, `--out`, npath.fromPortablePath(`${tempDir}/${rndName}.tgz`)], { | ||
| cwd: npath.toPortablePath(__dirname), | ||
| }); | ||
| expect(packed.code).toEqual(0); | ||
|
|
||
| await xfs.writeJsonPromise(`${tempDir}/package.json` as PortablePath, {name: `test-esmodule`}); | ||
| await xfs.writeFilePromise(`${tempDir}/yarn.lock` as PortablePath, ``); | ||
|
|
||
| const added = await execUtils.execvp(`yarn`, [`add`, `./${rndName}.tgz`], {cwd: tempDir}); | ||
| expect(added.code).toEqual(0); | ||
|
|
||
| await xfs.writeFilePromise(`${tempDir}/index.mjs` as PortablePath, | ||
| `import {Command, Option, runExit} from 'clipanion'; | ||
| runExit(class MainCommand extends Command { | ||
| name = Option.String(); | ||
| async execute() { | ||
| this.context.stdout.write(\`Hello \${this.name}!\\n\`); | ||
| } | ||
| })`, | ||
| ); | ||
|
|
||
| const result = await execUtils.execvp(`node`, [`${tempDir}/index.mjs`, `World`], {cwd: tempDir}); | ||
| expect(result).toEqual({ | ||
| code: 0, | ||
| stderr: ``, | ||
| stdout: `Hello World!\n`, | ||
| }); | ||
| }); | ||
| }, 20000); | ||
|
|
||
| it(`works with TypeScript's Node16 resolution`, async () => { | ||
| await xfs.mktempPromise(async tempDir => { | ||
| const rndName = Math.floor(Math.random() * 100000000).toString(16).padStart(8, `0`); | ||
|
|
||
| const packed = await execUtils.execvp(`yarn`, [`pack`, `--out`, npath.fromPortablePath(`${tempDir}/${rndName}.tgz`)], { | ||
| cwd: npath.toPortablePath(__dirname), | ||
| }); | ||
| expect(packed.code).toEqual(0); | ||
|
|
||
| await xfs.writeJsonPromise(`${tempDir}/package.json` as PortablePath, {name: `test-ts-node16`}); | ||
| await xfs.writeFilePromise(`${tempDir}/yarn.lock` as PortablePath, ``); | ||
|
|
||
| const added = await execUtils.execvp(`yarn`, [`add`, `./${rndName}.tgz`], {cwd: tempDir}); | ||
| expect(added.code).toEqual(0); | ||
|
|
||
| await execUtils.execvp(`yarn`, [`add`, `-D`, `typescript`], {cwd: tempDir}); | ||
|
|
||
| const tsconfig = { | ||
| compilerOptions: { | ||
| target: `esnext`, | ||
| module: `node16`, | ||
| moduleResolution: `node16`, | ||
| skipLibCheck: true, | ||
| noEmit: true, | ||
| }, | ||
| }; | ||
| await xfs.writeFilePromise(`${tempDir}/tsconfig.json` as PortablePath, JSON.stringify(tsconfig, null, 2)); | ||
|
|
||
| await xfs.writeFilePromise(`${tempDir}/index.ts` as PortablePath, | ||
| `import {Command, Option, runExit} from 'clipanion'; | ||
| import * as P from 'clipanion/platform'; | ||
| `, | ||
| ); | ||
|
|
||
| const result = await execUtils.execvp(`yarn`, [`tsc`], {cwd: tempDir}); | ||
| expect(result).toEqual({ | ||
| code: 0, | ||
| stderr: ``, | ||
| stdout: ``, | ||
| }); | ||
| }); | ||
| }, 20000); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,8 @@ | |
| "rootDir": "sources", | ||
| "outDir": "lib", | ||
| "types": [ | ||
| "node" | ||
| "node", | ||
| "rollup" | ||
| ] | ||
| }, | ||
| "include": [ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.