Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a partial function macro @$ #7

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Jul 1, 2023

This allows us to create Partial Functions where arguments at arbitrary indices are missing.

@archermarx
Copy link
Owner

This looks cool! Give me a day or two to look through this in detail. I'm out of town and away from my computer currently.

Copy link
Owner

@archermarx archermarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! My one thought: would it be possible to merge the GeneralizedPartialFunction struct with the base PartialFunction struct? That way we can reduce some code duplication

@avik-pal
Copy link
Contributor Author

avik-pal commented Jul 4, 2023

Let me go through the implementation and try that. I agree it will reduce code duplication.

Copy link
Owner

@archermarx archermarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm currently in the middle of fixing some of the CI on this repo. Once that is fixed, I'll try and run CI on this branch

@archermarx archermarx merged commit 74ba57d into archermarx:master Jul 5, 2023
4 of 5 checks passed
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@3089264). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   97.22%           
=========================================
  Files             ?        2           
  Lines             ?       72           
  Branches          ?        0           
=========================================
  Hits              ?       70           
  Misses            ?        2           
  Partials          ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3089264...353bc47. Read the comment docs.

@avik-pal avik-pal deleted the ap/generalized branch July 5, 2023 14:42
@archermarx
Copy link
Owner

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants