11708 handle list of search results for permission_backend.get_search_ui_permissions
#11709
+158
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatisgalen
changed the title
permission_backend.get_search_ui_permissions
| @@ -142,6 +142,9 @@ def get_permission_search_filter(self, user): ... | |||
| @abstractmethod | |||
| def get_search_ui_permissions(self, user, search_result, groups=None): ... | |||
|
|
|||
| @abstractmethod | |||
There was a problem hiding this comment.
Hey Galen. I haven't looked too closely yet, but can you share why would we need a separate method if the signature is the same as get_search_ui_permissions?
There was a problem hiding this comment.
I actually ended up just updating the original logic of the get_search_ui_permissions method to handle either a dict or a list of search results and return back the like. I wanted to ensure this wouldn't be a breaking change.
|
While I think it would be really great to have this performance improvement 7.6, I feel that it is just too significant a change to go in a patch release. I think it should instead target the 8.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
This PR addresses the fact that an ORM query gets called for each individual search result whenever
get_search_ui_permissionsgets called. None of the actual logic has been altered, however now the method accepts either a single search_resultdictor alistof them, returning the same type of thing as it received. This means the ORM query to lookup nodegroup permissions now happens once for a set of results, significantly speeding up performance on larger sets of search_results. The Search Results filter has been updated to send/receive a list.Issues Solved
Closes #11708
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments