Realtime shadows #5
Conversation
Aadjou
commented
Jun 30, 2017
Aadjou
commented
- added support for shadowmaps in fragment & vertex shader
- adjusted the example to show how to set shadow attributes to overwrite stadow attributes that come from data3d material
| <a-entity base-product="id:10a54bcf-3b9c-4518-b7ea-81c4251cf5a4" position="-0.85 -5 -5.4"></a-entity> | ||
| <a-entity base-product="id:6070873f-1415-4846-ae40-95f3a4e49ff5" position="-0.82 -5 -0.6" rotation="0.0 180.0 0.0"></a-entity> | ||
| <!-- object shadow attributes | ||
| receive - toggle object receives realtime shadow (true or false, valid for entire object) |
There was a problem hiding this comment.
Just wondering: what does "entire object" mean? As far as the code goes, there's only one object (one a-entity for each, one product, one data3d). Does that also apply if I nest children into this?
So if I have
<a-entity base-data3d="..." shadow="receive:true">
<a-box></a-box>
</a-entity>does the shadow property also apply to that child? I actually don't even know if we support children, but I'm curious now ^^
There was a problem hiding this comment.
that i don't know. i can test it out with a regular a-frame scene and children.
This is a-frame functionality.
if you set the receive/cast-shadows flag, it applies to the entire data3d geometry and all the materials. Else it will take it from the material properties.
| --> | ||
| <a-entity base-data3d="key:/fd72bf39-9d3a-471f-a4ff-ecaa3f5ff30b/bake/2017-04-15_22-45-14_XsiltX/regular/lighting.gz.data3d.buffer" position="0 -5 -6" shadow="receive: true"></a-entity> | ||
| <a-entity base-product="id:10a54bcf-3b9c-4518-b7ea-81c4251cf5a4" position="-0.85 -5 -5.4" shadow="cast: true" ></a-entity> | ||
| <a-entity base-product="id:e1ac1efb-7505-449a-b493-680fcfb2f3a6" position="-0.82 -5 -0.6" shadow="cast: true" rotation="0.0 180.0 0.0"></a-entity> |
There was a problem hiding this comment.
Would it make sense to have one product that also receives shadows?
There was a problem hiding this comment.
yes. Also the question is still open why the products do not show the cast-shadows (that is in their material definitions from Archilogic) when importing in a-frame.
because if i download one of the data3d files from the editor, it is set there.
that is maybe something we should look at before or after merging the pull request
|
what will we do with this? @AVGP i suggest opening an issue for the products shadows and then merge. |
|
I agree 👍 |
|
#6 - issue created from discussion. |
