-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborate? #10
Comments
Hi Jeff, Thank you for your kind words. I'm happy that you're enjoying this project and would like to extend it. As the code is currently, I believe the
I'll be happy to discuss these issues further and to integrate these changes into the project. Feel free to create a PR/more issues with ideas and questions! |
Thanks, this is helpful and mostly inline with how I felt after reading the code base. We have a pretty strong unit testing practice at Koyal Tech, and will endeavor to contribute some basics in that regard. 👍 Just so you're aware, I did an MVP to get it modularized and able to import, but I know further enhancements will be required before it is useful enough to merge back in. |
I have to thank you for your work. This repo inspire me to create a plugin in Obsidian.md, and I shared this repo link inside the readme.md as source. If I achieve another kind of cell (calendar, image...) I will share it here too! |
As I promise, I dev the Calendar column type using react-calendar npm dependency feel free to check it =) |
Is it possible to create an installable package? |
Thanks for the feedback @jeff-r-koyaltech @RafaelGB @joseph-vedadi ! Will be using #13 to track creating a package. |
Hi @archit-p , I just wanted you to know that I'm enjoying the table feature you've built for React. I'm hacking away in a fork, trying to get it to a point where it can be easily installed into an existing React project via npm module. That's my main need right now, because I would hope to use it in a few internal projects for our Mumbai-based company.
Take a look and let me know if you'd be interested in trying to work out a way to merge these together before I deviate from your code base too much. If so, I'd like to hear specifically what it would take in your view to remain compatible with however you're already using it.
https://github.com/koyal-tech/editable-react-table
Warm regards,
Jeff
The text was updated successfully, but these errors were encountered: