Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remapping problem #5

Open
PlanetTeamSpeakk opened this issue May 2, 2022 · 0 comments
Open

Remapping problem #5

PlanetTeamSpeakk opened this issue May 2, 2022 · 0 comments

Comments

@PlanetTeamSpeakk
Copy link

The way the template currently handles shadowing ignores the fact that subprojects may use different mappings.
Instead of remapping every dependency and then merging all the remapped jars into one, all dependencies are first merged into a single jar, after which that jar is remapped using the mappings of the project that does the remapping. This means that any subproject dependency that uses different mappings still get remapped with the mappings of the remapping project which is especially an issue if subprojects are not built against the same Minecraft version as the remapping project as classes that were renamed and/or deleted simply do not get remapped causing NoClassDefFoundErrors when using the mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant