Skip to content
This repository has been archived by the owner on Sep 9, 2021. It is now read-only.

Update NER. Make slider work and use moment dates. #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thegsi
Copy link

@thegsi thegsi commented Jul 13, 2018

What does this Pull Request do?

  • Added moment.js library to make date display and queries more manageable.
  • Refactored slider range functions
  • Improve/fix slider range functionality

How should this be tested?

  • Slider did not work effectively
  • To test uncomment the JSON object
  • Add as JSON file
  • However a bigger JSON file is required really as we found the visualisation wouldn't work with larger files.

Additional Notes:

PR is to put code out there to test whether this repo is still in use/potential for development.
Perhaps the repo could be broken into three separate repos?

Interested parties

@ianmilligan1
@ruebot

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the .gitignore file from this pull request?

Also, I've been trying to get this to run locally and am getting this error.

screen shot 2018-07-19 at 2 53 11 pm

TypeError: undefined is not an object (evaluating `momentDates[i].diff'    index.html:315

I'm running this with my own sample files, which I have a few laying around here: https://github.com/ianmilligan1/McLuhan/tree/master/NER.

You know more about visualizations than I do so I may be doing something wrong here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants