Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Add Replay link; Resolves #19 #35

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add Replay link; Resolves #19 #35

merged 1 commit into from
Oct 18, 2017

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Oct 18, 2017

  • Create an accessor that uses to Solr fields to query Time Travel API
  • Display accessor as a field
  • Create a test
  • Update Rubocop to ignore somethings; TODO create tickets, and come back to this later

Should have a replay url display like this:
screenshot from 2017-10-18 11-17-27

* Create an accessor that uses to Solr fields to query Time Travel API
* Display accessor as a field
* Create a test
* Update Rubocop to ignore somethings; TODO create tickets, and come back to this later
@ruebot
Copy link
Member Author

ruebot commented Oct 18, 2017

Rubocop follow-up tickets: #36, #37

@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      5    +1     
  Lines          18     32   +14     
=====================================
+ Hits           18     32   +14
Impacted Files Coverage Δ
app/models/concerns/warclight/solr_document.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b45717...cd7c3df. Read the comment docs.

@ianmilligan1 ianmilligan1 merged commit bd65cd8 into master Oct 18, 2017
@ianmilligan1 ianmilligan1 deleted the issue-19 branch October 18, 2017 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants