Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Enum-like objects #2621

Open
e-moran opened this issue Dec 18, 2024 · 3 comments
Open

Deprecate Enum-like objects #2621

e-moran opened this issue Dec 18, 2024 · 3 comments
Assignees

Comments

@e-moran
Copy link
Contributor

e-moran commented Dec 18, 2024

This issue is related to #1833.

We must first deprecate the Enum-like objects before we remove them though.

We should add JSDoc so editors apply strikethrough to any usage and a changelog entry.

@blaine-arcjet
Copy link
Contributor

I don't think we should add a warning log. I think we should add JSDoc so editors apply strikethrough to any usage and a changelog entry.

@davidmytton
Copy link
Contributor

Agree that adding a warning is not ideal because it could pollute the logs on every request. Let's use the doc comments and include it in the change log/release notes.

@e-moran
Copy link
Contributor Author

e-moran commented Dec 19, 2024

Sounds good! I've updated the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants