Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-beta changes #928

Open
17 of 19 tasks
blaine-arcjet opened this issue Jun 11, 2024 · 11 comments
Open
17 of 19 tasks

Pre-beta changes #928

blaine-arcjet opened this issue Jun 11, 2024 · 11 comments
Assignees

Comments

@davidmytton
Copy link
Contributor

All these make sense to me except #539 unless we also do #782. eslint 9 has version conflicts with other packages so we should avoid forcing a breaking change release just for our internal packages.

@blaine-arcjet
Copy link
Contributor Author

I'm fine to skip the eslint upgrade but I think we're in agreement to decouple the version numbers of our devDeps so we can make breaking changes in the future without affecting the SDK version numbers.

@davidmytton
Copy link
Contributor

Yes, agreed.

@blaine-arcjet
Copy link
Contributor Author

We're putting this on hold until we're ready to approach beta again.

@e-moran
Copy link
Contributor

e-moran commented Aug 7, 2024

We should rename the block field in validateEmail to align with the allow/deny naming of other rules.

@blaine-arcjet
Copy link
Contributor Author

I've been discussing with @e-moran about making the wholesale switch from SCREAMING_SNAKE_CASE to kebab-case for our enum-like values. This would match the output of jco and require less translation when calling Wasm.

@blaine-arcjet
Copy link
Contributor Author

Remove the ability to construct multiple rules with one constructor: #1397

@e-moran
Copy link
Contributor

e-moran commented Sep 3, 2024

I've been discussing with @e-moran about making the wholesale switch from SCREAMING_SNAKE_CASE to kebab-case for our enum-like values. This would match the output of jco and require less translation when calling Wasm.

Do you think we should do this before the beta as its a big breaking change? I could have time to do it at the end of the week after the docs.

@blaine-arcjet
Copy link
Contributor Author

@e-moran I think we need to make this backwards compatible with warning logs for deprecated format. Would you be able to do that in the timeline suggested?

@blaine-arcjet
Copy link
Contributor Author

I think we should also consider removing the .ts files from our published packages. It is becoming frustrating that some frameworks/build tools process the .ts files even when our package manifest indicates that we provide the .js and .d.ts files.

@blaine-arcjet blaine-arcjet assigned e-moran and unassigned davidmytton Sep 30, 2024
@blaine-arcjet blaine-arcjet changed the title Pre-beta breaking changes Pre-beta changes Oct 2, 2024
@blaine-arcjet
Copy link
Contributor Author

I believe I've migrated all suggestions in this thread to issues and update the root checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants