Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factoring out site parameters in config.arc? #129

Open
bzg opened this issue Nov 4, 2018 · 3 comments
Open

Factoring out site parameters in config.arc? #129

bzg opened this issue Nov 4, 2018 · 3 comments

Comments

@bzg
Copy link

bzg commented Nov 4, 2018

news.arc contains configuration variables like this-site*.

I think it would make sense to store configuration variables in a separate file.

What do you think?

@akkartik
Copy link
Member

akkartik commented Nov 4, 2018

Sure, feel free to make that change.

The reason it hasn't happened is that Arc tends to encourage us to stay close to the codebase so that we gradually come to understand its internals. Configuration variables in code are just one aspect of that ethos. Do you have some context that prefers isolating configuration variables from code?

Sometimes the best way to figure out why things are the way they are is to change them and see if somebody complains. In code, changing and reverting are easy operations.

@hjek
Copy link
Contributor

hjek commented Nov 4, 2018

@bzg, I think that is a great idea. If you are running a News site, you basically lose your site configuration every time you do a git pull. It's just not a good idea to have the config in the same file as the code.

@akkartik
Copy link
Member

akkartik commented Nov 4, 2018

Good to know this is a source of pain. I haven't spent any time maintaining a News app. I believe the recommended solution is to run off a branch that you periodically merge master into.

@kennethrapp kennethrapp added this to Requested in Arc Forum Updates Aug 31, 2019
@kennethrapp kennethrapp moved this from Requested to In Progress in Arc Forum Updates Feb 15, 2020
@kennethrapp kennethrapp moved this from In Progress to Requested in Arc Forum Updates Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants