Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Specification constructors as public. #413

Open
Tracked by #427
fiseni opened this issue Nov 9, 2024 · 0 comments · May be fixed by #431
Open
Tracked by #427

Update Specification constructors as public. #413

fiseni opened this issue Nov 9, 2024 · 0 comments · May be fixed by #431
Assignees
@fiseni

Comments

@fiseni
Copy link
Collaborator

fiseni commented Nov 9, 2024 •
edited
Loading

In the previous versions, we exposed the Query as public. The detailed rationale behind that decision is provided in this issue #250

We might also refactor the constructors as public instead of protected. There is no compeling reason why they should be protected. On the other hand, having them public would benefit the consumers in certain scenarios.
@fiseni fiseni mentioned this issue Nov 9, 2024
Open
15 tasks
@fiseni fiseni linked a pull request Dec 20, 2024 that will close this issue
Open
@fiseni fiseni self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fiseni fiseni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor specification constructors as public. ardalis/Specification
1 participant
@fiseni