Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol-valued properties are not copied #6499

Open
4 tasks
gabrielschulhof opened this issue Sep 6, 2024 · 0 comments
Open
4 tasks

Symbol-valued properties are not copied #6499

gabrielschulhof opened this issue Sep 6, 2024 · 0 comments

Comments

@gabrielschulhof
Copy link

gabrielschulhof commented Sep 6, 2024

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the GraphQL Tools package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

mock strips property symbols.

To Reproduce Steps to reproduce the behavior:

At https://github.com/ardatan/graphql-tools/blob/master/packages/mock/src/utils.ts#L34, the code does not iterate over getOwnPropertySymbols.

Expected behavior

Objects are copied, including their symbol-keyed properties.

Environment:

  • OS:
  • @graphql-tools/...:
  • NodeJS:

Additional context

I don't understand why these properties are skipped. In fact, there is a test to ensure that they are skipped. It was added at 6877b91. Would it be possible to not skip these properties?

Background: We use symbols for annotating and resolving abstract types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant