EthernetClient::write returns wrong value when buffer size exceeds W5100.SSIZE #141

rayshobby · 2020-07-19T02:12:28Z

The return value of EthernetClient::write should be the return value of Ethernet::socketSend:

Line 86 in 75a3c37

if (Ethernet.socketSend(sockindex, buf, size)) return size;

Otherwise if the buffer to be sent is larger than W5100.SSIZE it will only send W5100.SSIZE number of characters,
https://github.com/arduino-libraries/Ethernet/blob/master/src/socket.cpp#L428
yet EthernetClient::write still returns 'size'.

A better way to implement EthernetClient::write is to add a loop until the whole content is sent.

per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 22, 2022

per1234 linked a pull request Mar 30, 2022 that will close this issue

Fix erroneous return value of EthernetClient::write() #187

Open

per1234 linked a pull request Nov 23, 2023 that will close this issue

address issues 139 and 141 #142

Open

per1234 linked a pull request Nov 23, 2023 that will close this issue

Fix the write function to return the actual number of bytes sent. #242

Open

Provide feedback