Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI API add void transfer(const void *tx_buffer, void *rx_buffer, size_t count); #243

Open
ag88 opened this issue Jan 10, 2025 · 0 comments

Comments

@ag88
Copy link

ag88 commented Jan 10, 2025

API component

SPI API

Description

SPI API add

virtual void transfer(const void *tx_buffer, void *rx_buffer, size_t count);

Expand SPI API and Functionality for High Speed Devices

Is this a breaking change?

Unlikely

Additional information

This is really a missing API method, it doesn't make sense to have only a single buffer for both transmit and receive, as DMA hardware normally works in 2 buffers.
The plain old
https://github.com/arduino/ArduinoCore-API/blob/master/api/HardwareSPI.h#L112

  virtual void transfer(void *buf, size_t count) = 0;

forces hacks such as:

  • allocate a temporary buffer
  • do the DMA transfers receiving into the temporary buffer
  • copy that temporary buffer data back into the address pointed by buf
    wasting both memory and cpu cycles
@ag88 ag88 changed the title SPI API add void transfer(const void *tx_buf, void *rx_buf, size_t count); SPI API add void transfer(const void *tx_buffer, void *rx_buffer, size_t count); Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant