github: fix verify jobs to always report status

Fix verify-core and verify-format jobs that were causing GitHub PR
status checks to get stuck with "Waiting for status to be reported".
Both jobs now use 'if: always()' to ensure they run and report status
regardless of dependency job outcomes.

Signed-off-by: iabdalkader <[email protected]>

Author: iabdalkader

.github/workflows/format_check.yml

@@ -58,3 +58,20 @@ jobs:
           clang-format-version: '19'
           check-path: ${{ matrix.path['check'] }}
           exclude-regex: ${{ matrix.path['exclude'] }}
+
+  verify-format:
+    name: verify-format
+    runs-on: ubuntu-latest
+    if: always()
+    needs: format-check
+    steps:
+      - name: Check format results
+        run: |
+          if [[ "${{ needs.format-check.result }}" == "skipped" ]]; then
+            echo "Format check was skipped"
+          elif [[ "${{ needs.format-check.result }}" == "failure" || "${{ needs.format-check.result }}" == "cancelled" ]]; then
+            echo "Format check failed or was cancelled"
+            exit 1
+          else
+            echo "Format check completed successfully"
+          fi

.github/workflows/package_core.yml

@@ -30,6 +30,8 @@ jobs:
       - name: Initialize Zephyr environment
         run: |
           yes | ./extra/bootstrap.sh -o=--filter=tree:0
+          source venv/bin/activate
+          echo "ZEPHYR_SDK_INSTALL_DIR=$(west config sdk.base-dir)" >> "$GITHUB_ENV"
           echo "CORE_TAG=$(git describe --tags --exact-match || git describe --always)" >> "$GITHUB_ENV"
           echo "CORE_ARTIFACT=ArduinoCore-zephyr-$(git describe --always)" >> "$GITHUB_ENV"
           echo "BOARD_VARIANTS=$(extra/get_board_details.sh | jq -cr 'sort_by(.variant)')" >> "$GITHUB_ENV"
@@ -42,6 +44,7 @@ jobs:
       - name: Build variants
         shell: bash
         run: |
+          source venv/bin/activate
           ./extra/build_all.sh -f
 
       - name: Package core
@@ -184,15 +187,21 @@ jobs:
           failOnError: false
 
   verify-core:
-    name: Collect job errors
+    name: verify-core
     runs-on: ubuntu-latest
-    if: cancelled() || contains(needs.*.result, 'failure')
+    if: always()
     needs:
       - package-core
       - test-core
     steps: 
-      - name: Notify failure
-        run: exit 1
+      - name: Check job results
+        run: |
+          if [[ "${{ needs.package-core.result }}" == "failure" || "${{ needs.test-core.result }}" == "failure" || "${{ needs.package-core.result }}" == "cancelled" || "${{ needs.test-core.result }}" == "cancelled" ]]; then
+            echo "One or more required jobs failed or were cancelled"
+            exit 1
+          else
+            echo "All required jobs completed successfully"
+          fi
 
   publish-core:
     name: Publish core