Skip to content

Commit

Permalink
remove buildPath parameter to PrepareSketchBuildPath func
Browse files Browse the repository at this point in the history
  • Loading branch information
alessio-perugini committed Sep 12, 2023
1 parent f1c5cc5 commit 1ebabcd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions arduino/builder/sketch.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ func (b *Builder) Sketch() *sketch.Sketch {
// PrepareSketchBuildPath copies the sketch source files in the build path.
// The .ino files are merged together to create a .cpp file (by the way, the
// .cpp file still needs to be Arduino-preprocessed to compile).
func (b *Builder) PrepareSketchBuildPath(sourceOverrides map[string]string, buildPath *paths.Path) (int, error) {
if err := buildPath.MkdirAll(); err != nil {
func (b *Builder) PrepareSketchBuildPath(sourceOverrides map[string]string) (int, error) {
if err := b.buildPath.MkdirAll(); err != nil {
return 0, errors.Wrap(err, tr("unable to create a folder to save the sketch"))
}

Expand All @@ -58,12 +58,12 @@ func (b *Builder) PrepareSketchBuildPath(sourceOverrides map[string]string, buil
return 0, err
}

destFile := buildPath.Join(b.sketch.MainFile.Base() + ".cpp")
destFile := b.buildPath.Join(b.sketch.MainFile.Base() + ".cpp")
if err := destFile.WriteFile([]byte(mergedSource)); err != nil {
return 0, err
}

if err := b.sketchCopyAdditionalFiles(buildPath, sourceOverrides); err != nil {
if err := b.sketchCopyAdditionalFiles(b.buildPath, sourceOverrides); err != nil {
return 0, err
}

Expand Down
4 changes: 2 additions & 2 deletions legacy/builder/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (s *Builder) Run(ctx *types.Context) error {
}),

types.BareCommand(func(ctx *types.Context) error {
ctx.LineOffset, _err = ctx.Builder.PrepareSketchBuildPath(ctx.SourceOverride, ctx.Builder.GetSketchBuildPath())
ctx.LineOffset, _err = ctx.Builder.PrepareSketchBuildPath(ctx.SourceOverride)
return _err
}),

Expand Down Expand Up @@ -319,7 +319,7 @@ func (s *Preprocess) Run(ctx *types.Context) error {
}),

types.BareCommand(func(ctx *types.Context) error {
ctx.LineOffset, _err = ctx.Builder.PrepareSketchBuildPath(ctx.SourceOverride, ctx.Builder.GetSketchBuildPath())
ctx.LineOffset, _err = ctx.Builder.PrepareSketchBuildPath(ctx.SourceOverride)
return _err
}),

Expand Down

0 comments on commit 1ebabcd

Please sign in to comment.