From a38853b87889ede62384e1e178877bc752f1006c Mon Sep 17 00:00:00 2001 From: Alessio Perugini Date: Mon, 11 Sep 2023 13:03:15 +0200 Subject: [PATCH] apply CR suggestion --- legacy/builder/builder.go | 2 +- legacy/builder/warn_about_arch_incompatible_libraries.go | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/legacy/builder/builder.go b/legacy/builder/builder.go index 500575374e3..0e1156666e6 100644 --- a/legacy/builder/builder.go +++ b/legacy/builder/builder.go @@ -458,7 +458,7 @@ func containerBuildOptions(ctx *types.Context) types.BareCommand { func warnAboutArchIncompatibleLibraries(ctx *types.Context) types.BareCommand { return types.BareCommand(func(ctx *types.Context) error { overrides, _ := ctx.BuildProperties.GetOk("architecture.override_check") - _ = WarnAboutArchIncompatibleLibraries( + WarnAboutArchIncompatibleLibraries( ctx.TargetPlatform, overrides, ctx.SketchLibrariesDetector.ImportedLibraries(), diff --git a/legacy/builder/warn_about_arch_incompatible_libraries.go b/legacy/builder/warn_about_arch_incompatible_libraries.go index 954fbb047d3..ea7392560bc 100644 --- a/legacy/builder/warn_about_arch_incompatible_libraries.go +++ b/legacy/builder/warn_about_arch_incompatible_libraries.go @@ -27,7 +27,7 @@ func WarnAboutArchIncompatibleLibraries( overrides string, importedLibraries libraries.List, printInfoFn func(string), -) error { +) { archs := []string{targetPlatform.Platform.Architecture} if overrides != "" { archs = append(archs, strings.Split(overrides, ",")...) @@ -42,6 +42,4 @@ func WarnAboutArchIncompatibleLibraries( strings.Join(archs, ", "))) } } - - return nil }