From 6f496c5c8cad54b36d36e0ee85e95659f3cd301b Mon Sep 17 00:00:00 2001 From: Akos Kitta Date: Fri, 16 Feb 2024 14:25:26 +0100 Subject: [PATCH] fix: stricter assertion for optional programmer Signed-off-by: Akos Kitta --- .../src/test/browser/debug.test.ts | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/arduino-ide-extension/src/test/browser/debug.test.ts b/arduino-ide-extension/src/test/browser/debug.test.ts index 0246abb4e..e66cd65a0 100644 --- a/arduino-ide-extension/src/test/browser/debug.test.ts +++ b/arduino-ide-extension/src/test/browser/debug.test.ts @@ -116,6 +116,23 @@ describe('debug', () => { ); }); + it('should resolve when no programmer is selected (arduino/arduino-cli#2540)', async () => { + const copyData: Mutable = deepClone(data); + delete copyData.selectedProgrammer; + await doesNotReject( + isDebugEnabled( + board, + () => boardDetails, + () => copyData, + (fqbn) => fqbn, + async (params) => { + expect(params.programmer).to.be.undefined; + return params.fqbn; + } + ) + ); + }); + it('should error when it fails to get the debug info from the CLI', async () => { await rejects( isDebugEnabled( @@ -133,20 +150,6 @@ describe('debug', () => { ); }); - it('should resolve when no programmer is selected (arduino/arduino-cli#2540)', async () => { - const copyData: Mutable = deepClone(data); - delete copyData.selectedProgrammer; - await doesNotReject( - isDebugEnabled( - board, - () => boardDetails, - () => copyData, - (fqbn) => fqbn, - async () => fqbn - ) - ); - }); - it('should resolve when debugging is supported', async () => { await doesNotReject( isDebugEnabled(