From f507341e68410aa3f9d551920d49f32724a80176 Mon Sep 17 00:00:00 2001 From: Akos Kitta Date: Fri, 10 Mar 2023 17:05:53 +0100 Subject: [PATCH] fix: ignore arduino.cloud.push.warn when creating a cloud copy Signed-off-by: Akos Kitta --- .../src/browser/contributions/create-cloud-copy.ts | 2 +- .../widgets/cloud-sketchbook/cloud-sketchbook-tree.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arduino-ide-extension/src/browser/contributions/create-cloud-copy.ts b/arduino-ide-extension/src/browser/contributions/create-cloud-copy.ts index b116f549e..73b967f0f 100644 --- a/arduino-ide-extension/src/browser/contributions/create-cloud-copy.ts +++ b/arduino-ide-extension/src/browser/contributions/create-cloud-copy.ts @@ -95,7 +95,7 @@ export class CreateCloudCopy extends CloudSketchContribution { ); progress.report({ message: pushingSketch(newSketch.name) }); - await treeModel.sketchbookTree().push(newNode, true); + await treeModel.sketchbookTree().push(newNode, true, true); }; return this.commandService.executeCommand( NewCloudSketch.Commands.NEW_CLOUD_SKETCH.id, diff --git a/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts b/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts index 207b28158..9a5571da2 100644 --- a/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts +++ b/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts @@ -174,7 +174,8 @@ export class CloudSketchbookTree extends SketchbookTree { async push( node: CloudSketchbookTree.CloudSketchDirNode, - noProgress = false + noProgress = false, + ignorePushWarnings = false ): Promise { if (!CloudSketchbookTree.CloudSketchTreeNode.isSynced(node)) { throw new Error( @@ -190,7 +191,8 @@ export class CloudSketchbookTree extends SketchbookTree { return; } - const warn = this.arduinoPreferences['arduino.cloud.push.warn']; + const warn = + !ignorePushWarnings && this.arduinoPreferences['arduino.cloud.push.warn']; if (warn) { const ok = await new DoNotAskAgainConfirmDialog({