Some Theia settings have no effect, problematic decriptions, or are ignored on startup

[boundmaidlea]

Describe the problem

Settings

• editor.padding.bottom
• editor.padding.top
• window.menuBarVisibility
• window.titleBarStyle
• workbench.editor.highlightModifiedTabs

have no effect at all, even though it would be desirable to have these settings changable, and breadcrumbs.enabled only works in specific circumstances, but otherwise doesn't fulfill any actual purpose atm (showing the file's path), even though it could.

---

The settings

• editor.guides.bracketPairsHorizontal
• editor.minimap.scale

will be saved in the settings.json file, but are not read on startup and need to be re-set in the settings to take effect.

---

Further the description of the editor.language.colorizedBracketPairs setting's description states

Use 'workbench.colorCustomizations' to override the bracket highlight colors.

Even though the workbench.colorCustomizations setting is not supported by this IDE at the moment.

---

The description of application.confirmExit seems to assume that the app runs in browser even if it doesn't.

To reproduce

• open the command palette
• use the Preferences: Open Settings (UI) command
• change or look at one of the mentioned settings

Expected behavior

all mentioned settings do what they are described to do and vice versa.

Arduino IDE version

2.0.0-rc7-nightly-20220615

Operating system

Windows

Operating system version

10.0.19044.1706 Pro

Additional context

My Nightly Build is 4 days old, but the 3 commits since then do not have any relations to this issue.

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details

[per1234]

Thanks for your report @boundmaidlea!

I did an investigation and my findings are as follows:

---

The following settings have been fixed upstream in the Eclipse Theia repository by eclipse-theia/theia#11711. So these will also be fixed in Arduino IDE once the Theia dependency is bumped to the one with the fix:

• editor.padding.bottom
• editor.guides.bracketPairsHorizontal
• editor.minimap.scale

---

I can reproduce breadcrumbs.enabled not having any effect (I'm using Arduino IDE 2.0.1-snapshot-bc264d1). It works as expected in version 1.25.0 (same as Arduino IDE's current Theia dependency) of Theia Blueprint. I didn't find any cases where it did work. @boundmaidlea please describe the the specific cases where you found it to have an effect as this might be useful for the investigation.

---

I can reproduce window.titleBarStyle not having any effect. It works as expected in Blueprint 1.25.0.

---

I found that window.menuBarVisibility requires the window to be reloaded before it takes effect. This behavior is unique to Arduino IDE. The change takes effect immediately in Blueprint 1.25.0.

---

I found that workbench.editor.highlightModifiedTabs also does not have any effect with the latest version of Theia (eclipse-theia/theia@e96bb5b).

---

I was not able to reproduce the problem reported with editor.padding.top. This setting works as expected for me in Arduino IDE even when using the 2.0.0-rc7 version from the report. @boundmaidlea are you still able to reproduce the problem with that setting?

---

The description of editor.language.colorizedBracketPairs no longer mentions the workbench.colorCustomizations setting:

Defines the bracket pairs that are colorized by their nesting level if bracket pair colorization is enabled.

It is mentioned in the editor.bracketPairColorization.enabled description:

Controls whether bracket pair colorization is enabled or not. Use 'workbench.colorCustomizations' to override the bracket highlight colors.

[per1234]

This issue was partially resolved by #1662

The remaining unresolved components:

• breadcrumbs.enabled has no effect
• window.titleBarStyle has no effect
• workbench.editor.highlightModifiedTabs has no effect

[per1234]

As I explained above, most of the reported problems were fixed upstream in Theia and those fixes have now been pulled into Arduino IDE via #1662. A new issue has been created to track the remaining problems reported here: #1733

So I will close this as resolved. Thanks @boundmaidlea!