From e4ba41ebe55f7491ca9f59fe8ae749a16bdba3af Mon Sep 17 00:00:00 2001 From: Jade Abraham Date: Thu, 5 Dec 2024 16:00:59 -0800 Subject: [PATCH] actually fix off-by-one Signed-off-by: Jade Abraham --- runtime/src/chpl-launcher-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/src/chpl-launcher-common.c b/runtime/src/chpl-launcher-common.c index d31d4b89b04e..c5abe13877ba 100644 --- a/runtime/src/chpl-launcher-common.c +++ b/runtime/src/chpl-launcher-common.c @@ -546,7 +546,7 @@ char* chpl_get_enviro_keys(char sep) int keyLen = strstr(environ[i], "=") - environ[i]; // if the key ends with _modshare, skip it - if (keyLen > 8 && strncmp(environ[i] + keyLen - 8, "_modshare", 9) == 0) { + if (keyLen > 8 && strncmp(environ[i] + keyLen - 9, "_modshare", 9) == 0) { continue; } numVars++; @@ -563,7 +563,7 @@ char* chpl_get_enviro_keys(char sep) int keyLen = strstr(environ[i], "=") - environ[i]; // skip keys that end with _modshare - if (keyLen > 8 && strncmp(environ[i] + keyLen - 8, "_modshare", 9) == 0) { + if (keyLen > 8 && strncmp(environ[i] + keyLen - 9, "_modshare", 9) == 0) { continue; } strncpy(buffer + bufferOffset, environ[i], keyLen);