From e7a502142e0c53f18030e3b5f2ef5ea5b2a443c9 Mon Sep 17 00:00:00 2001 From: Jade Abraham Date: Tue, 14 Nov 2023 14:24:51 -0800 Subject: [PATCH] resolve 2 futures Signed-off-by: Jade Abraham --- .../lydia/syntax-error-unclear-message.future | 10 ---------- .../functions/lydia/syntax-error-unclear-message.good | 2 +- .../lydia/syntax-error-unclear-message2.future | 11 ----------- .../lydia/syntax-error-unclear-message2.good | 2 +- 4 files changed, 2 insertions(+), 23 deletions(-) delete mode 100644 test/functions/lydia/syntax-error-unclear-message.future delete mode 100644 test/functions/lydia/syntax-error-unclear-message2.future diff --git a/test/functions/lydia/syntax-error-unclear-message.future b/test/functions/lydia/syntax-error-unclear-message.future deleted file mode 100644 index 16694be4ab2e..000000000000 --- a/test/functions/lydia/syntax-error-unclear-message.future +++ /dev/null @@ -1,10 +0,0 @@ -bug: Internal error for function declaration with missing body - -This incorrect function declaration currently fails with an obscure error message. -The problem should probably be caught closer to parsing so a more reasonable -message can be generated. - -At a guess, I would say this is related to our extern function implementation. - -When compiled with CHPL_DEVELOPER=true, the message generated is -problem.chpl:1: internal error: every return type must also have a ref type. [checkAST.cpp:267] diff --git a/test/functions/lydia/syntax-error-unclear-message.good b/test/functions/lydia/syntax-error-unclear-message.good index dccfd872ade8..5c0db0df360f 100644 --- a/test/functions/lydia/syntax-error-unclear-message.good +++ b/test/functions/lydia/syntax-error-unclear-message.good @@ -1 +1 @@ -problem.chpl:3: syntax error: near 'incomplete' +syntax-error-unclear-message.chpl:1: error: no-op procedures are only legal for extern functions diff --git a/test/functions/lydia/syntax-error-unclear-message2.future b/test/functions/lydia/syntax-error-unclear-message2.future deleted file mode 100644 index 276ac4c8c622..000000000000 --- a/test/functions/lydia/syntax-error-unclear-message2.future +++ /dev/null @@ -1,11 +0,0 @@ -bug: Internal error for function declaration with missing body - -This incorrect function declaration currently fails with an obscure error message. -The problem should probably be caught closer to parsing so a more reasonable -message can be generated. - -At a guess, I would say this is related to our extern function implementation. - -When compiled with CHPL_DEVELOPER=true, the message generated is -problem.chpl:1: In function 'incomplete': -problem.chpl:1: internal error: PRIM_INIT should have already been handled [functionResolution.cpp:7161] diff --git a/test/functions/lydia/syntax-error-unclear-message2.good b/test/functions/lydia/syntax-error-unclear-message2.good index dccfd872ade8..14a04db96440 100644 --- a/test/functions/lydia/syntax-error-unclear-message2.good +++ b/test/functions/lydia/syntax-error-unclear-message2.good @@ -1 +1 @@ -problem.chpl:3: syntax error: near 'incomplete' +syntax-error-unclear-message2.chpl:1: error: no-op procedures are only legal for extern functions