Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start of documentation and example scripts #1

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Start of documentation and example scripts #1

wants to merge 62 commits into from

Conversation

LukeSeifert
Copy link
Collaborator

This PR contains documentation for my planned approaches for handling spatial depletion in OpenMC, as well as some proof-of-concept work using a simplified PDE approach.

@LukeSeifert LukeSeifert added Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Docs Is related to API documentation, website content, etc. Type:Feature New feature or feature request labels Mar 17, 2024
@LukeSeifert LukeSeifert mentioned this pull request May 2, 2024
Closed
@LukeSeifert
Copy link
Collaborator Author

I'm going to close this PR in favor of PR #3 since there were so many changes in the refactor. Thank you for the review @samgdotson

@LukeSeifert LukeSeifert closed this May 2, 2024
@samgdotson
Copy link

@LukeSeifert, I understand there were a lot of changes. However, having a single commit history is important. If you made changes based on the comments on this PR, I want to be able to see those changes in the present context. Please merge #3 into #1 so I can see what you changed. Thanks!

@samgdotson samgdotson reopened this May 2, 2024
@yardasol
Copy link

@LukeSeifert do you still need a review on this?

@LukeSeifert
Copy link
Collaborator Author

@LukeSeifert do you still need a review on this?

Not yet, there are still some things I want to polish up first. I'll let you know when it's ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samgdotson samgdotson samgdotson requested changes

@yardasol yardasol Awaiting requested review from yardasol

@nglaser3 nglaser3 Awaiting requested review from nglaser3

@munkm munkm Awaiting requested review from munkm

@smpark7 smpark7 Awaiting requested review from smpark7

Assignees

@LukeSeifert LukeSeifert

Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Docs Is related to API documentation, website content, etc. Type:Feature New feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukeSeifert @pep8speaks @samgdotson @yardasol