Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Clean state when removing plugin #20

Open
CremaFR opened this issue Dec 14, 2022 · 1 comment
Open

Clean state when removing plugin #20

CremaFR opened this issue Dec 14, 2022 · 1 comment
Labels
question Further information is requested

Comments

@CremaFR
Copy link
Contributor

CremaFR commented Dec 14, 2022

In the current version, when removing a plugin, the state is not removed.
This could lead to unintuitive behavior, for instance:

A plugin with multiple signers is removed and re-added latter, all signers will be able to sign a for the acount, which for user coud lead to some confusion as when removing a plugin, one could expect the state to be cleaned.

Should we add a uninstall method to the plugin interface, to perform some state clean up, if necessary? Or manage this with a multicall (calls to clean the state with the last call to remove the plugin in the same transaction)

ps: I am aware for plugin like the sessionKey there is no solution to remove valid sessions on uninstall

@CremaFR CremaFR added the question Further information is requested label Dec 14, 2022
@tarrencev
Copy link
Contributor

Hmm yeah that's a good idea. We should add an uninstall method

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants