Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create inplace variants of math traits #384

Open
stefan-k opened this issue Jan 7, 2024 · 2 comments
Open

Create inplace variants of math traits #384

stefan-k opened this issue Jan 7, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stefan-k
Copy link
Member

stefan-k commented Jan 7, 2024

Due to the way the math traits are currently defined, no inplace operations are possible, often leading to unnecessary allocations. By adding inplace variants and changing solver code accordingly, we should be able to increase performance.

@stefan-k stefan-k added enhancement New feature or request good first issue Good for newcomers labels Jan 25, 2024
@jedbrown
Copy link

I think this is also one of the sticking points for no_std support, which would be an interesting feature (in particular, to use argmin inside GPU kernels).

@stefan-k
Copy link
Member Author

I think the entire argmin_math crate needs a refactoring with input from someone who has a better understanding of how to generalize the various math crates than I have. Performance and no_std support should then be amongst the main concerns. Being able to use argmin on GPUs would be really neat.

Unfortunately I won't be able to work on this in the near future, but I am happy to support any development in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants