Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation with Argo/GPT4o #565

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

keceli
Copy link
Contributor

@keceli keceli commented Dec 8, 2024

Similar to earlier PRs, using Argo/GPT4o to improve the services documentation. See issue #563.

…ossessive pronouns and verb agreement.

2. Fixed formatting issues, including consistent use of capitalization for terms like "GitLab Project" and "GitLab Group/SubGroup."
3. Improved clarity by rephrasing some sentences for better readability.
4. Added YAML syntax highlighting for code blocks to improve readability.
5. Ensured consistent use of terminology, such as "log in" instead of "login" when used as a verb.
…ency with the official branding.

2. Corrected capitalization: Changed "devops" to "DevOps" for consistency with standard terminology.
3. Improved formatting: Removed extra spaces before the link in the "GitLab-CI" section.
…esses" for subject-verb agreement.

2. Improved formatting: Removed unnecessary line break in the first bullet point for consistency.
… "Queue Name" section and added missing commas for clarity.

2. Improved clarity: Added "has" in "after the Notebook has started" for grammatical correctness.
3. Enhanced readability: Added backticks around `%pip` and `%conda` to indicate they are commands.
4. Corrected minor formatting issues: Ensured consistent use of punctuation and spacing throughout the document.
@felker felker self-requested a review January 10, 2025 23:22
Copy link
Member

@felker felker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some really good typo fixes and language improvements to the GitLab CI page, in particular. Lots of fiddling with newlines and whitespace, which can be kinda noisy.

the LLM is very opinionated on consistently removing hard wraps within a paragraph, probably because it makes it much more consistent and "source code-esque" throughout the repo, even though we havent really decided on a convention. See #330 and discussion in #317.

Thoughts @keceli? Maybe worth modifying the LLM prompt to minimize these changes? or should we continue to use it to make the line wrapping more uniform

@felker felker merged commit 43b59c9 into main Jan 10, 2025
1 check passed
@felker felker deleted the keceli_fix_argo_services branch January 10, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants