-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update operator-sdk version in the go.mod #461
Comments
could we bundle the argo-cd version change from |
That should be a different issue @jaideepr97 . Can you create one with the details ? |
@iam-veeramalla created #462 |
Hello! I would like to help out with this issue. From what I read, I have been following the linked issue, and there seems to be a migration guide from pre 1.0.0 versions (0.18+ in this case), but it involves recreating the project and mapping the APIs again. That does not sound like the right way to me, and I feel like I should only find replacements for the now private packages. So far I've found the following. For the k8sutils namespace, err := k8sutil.GetWatchNamespace() My idea is to replace it with the same function but in the operator codebase, as it only reads from a predefined env variable and returns a string. The Operator SDK version
I believe we should no longer print this out to the logs. I created a newly scaffolded project with the latest operator-sdk version and there's no trace of the operator-sdk libraries in the The tlsutil usage Looking at the code, I found the usage of the type cfg := &tlsutil.CertConfig{
CertName: secret.Name,
CertType: tlsutil.ClientAndServingCert,
CommonName: secret.Name,
Organization: []string{cr.ObjectMeta.Namespace},
} The properties in use are basically the same provided by the latter. The possible mapping could be:
The field I just looked at the test, but this is my plan so far. Please let me know what you think. As a disclaimer, although I have written go code and some small services before with it, I'm still learning to become more and become more fluent/confortable with it. Thanks in advance. |
I added a PR for this, checks are passing, Feedback would be nice |
@svghadi maybe we can work this out together too? :) would be willing to help with this, an initial pr i already submitted, but i think its not ready yet |
Sure @Elyytscha. Allow me some time to go through the issue and your PR. |
Describe the bug
operator-sdk
version in the go.mod is very old. We need to update it tov1.11.0
. Operator prints the sdk version using this dependency which will create a confusion to the users about the sdk version being used.While it looks simple and straight forward, it is slightly complicated. The new version of operator-sdk has structural changes w.r.t to packages. Some of the packages like
k8sutil
which is used by theargocd-operator
no longer exists in the new version ofoperator-sdk
. It is an internal package in the new version.Reference:
operator-framework/operator-sdk#3792
Expected behavior
Update the
operator-sdk
versionThe text was updated successfully, but these errors were encountered: