defered Unlock only when a lock is set

Signed-off-by: Akram Ben Aissi <[email protected]>
argoproj · Sep 6, 2023 · 42a109d · 42a109d
1 parent 588f582
commit 42a109d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controller/cache/cache.go b/controller/cache/cache.go
@@ -788,12 +788,12 @@ func (c *liveStateCache) handleModEvent(oldCluster *appv1.Cluster, newCluster *a
 func (c *liveStateCache) handleDeleteEvent(clusterServer string) {
 	c.lock.RLock()
 	c.clusterSharding.Delete(clusterServer)
-	defer c.lock.Unlock()
 	cluster, ok := c.clusters[clusterServer]
 	c.lock.RUnlock()
 	if ok {
 		cluster.Invalidate()
 		c.lock.Lock()
+		defer c.lock.Unlock()
 		delete(c.clusters, clusterServer)
 		c.lock.Unlock()
 	}