-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Namespace Selectors Support In Cluster Secrets #21846
base: master
Are you sure you want to change the base?
feat: Namespace Selectors Support In Cluster Secrets #21846
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Nebojsa Prodana <[email protected]>
29fcce1
to
aeafb4c
Compare
The EP #21835 is still to be discussed. I raised this PR to illustrate further what I am trying to achieve. Happy to add tests and documentation if the EP is approved. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21846 +/- ##
==========================================
- Coverage 55.60% 55.56% -0.05%
==========================================
Files 339 339
Lines 56869 56893 +24
==========================================
- Hits 31622 31612 -10
- Misses 22596 22630 +34
Partials 2651 2651 ☔ View full report in Codecov by Sentry. |
Signed-off-by: nebojsa-prodana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a documentation update. I started cleaning up some of the wording in #21865 while reviewing this PR.
I'm not sure that the namespace selector should cause namespaces
to be ignored. It seems like I would want to have the list of namespaces + labeled namespaces. WDYT?
Yeah, I considered both options and ended up proposing to make it exclusive since labelling namespaces is straightforward and aligns better with Kubernetes-native practices. This approach also makes it easier to phase out the CSV method for specifying namespaces over time. That said, I'm happy with either option—I'll leave it to the maintainers, as you have more insight into how this is being used and where you want to take it in the future. |
Fixes #21835
Checklist: