Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Namespace Selectors Support In Cluster Secrets #21846

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nebojsa-prodana
Copy link

Fixes #21835

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nebojsa-prodana nebojsa-prodana requested a review from a team as a code owner February 11, 2025 11:43
Copy link

bunnyshell bot commented Feb 11, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@nebojsa-prodana nebojsa-prodana force-pushed the cluster-secrets-ns-selector branch from 29fcce1 to aeafb4c Compare February 11, 2025 11:44
@nebojsa-prodana
Copy link
Author

nebojsa-prodana commented Feb 11, 2025

The EP #21835 is still to be discussed. I raised this PR to illustrate further what I am trying to achieve. Happy to add tests and documentation if the EP is approved.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 55.56%. Comparing base (8a447d9) to head (3b3616f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util/db/cluster.go 48.64% 18 Missing and 1 partial ⚠️
server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21846      +/-   ##
==========================================
- Coverage   55.60%   55.56%   -0.05%     
==========================================
  Files         339      339              
  Lines       56869    56893      +24     
==========================================
- Hits        31622    31612      -10     
- Misses      22596    22630      +34     
  Partials     2651     2651              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nebojsa-prodana <[email protected]>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a documentation update. I started cleaning up some of the wording in #21865 while reviewing this PR.

I'm not sure that the namespace selector should cause namespaces to be ignored. It seems like I would want to have the list of namespaces + labeled namespaces. WDYT?

@nebojsa-prodana
Copy link
Author

I'm not sure that the namespace selector should cause namespaces to be ignored. It seems like I would want to have the list of namespaces + labeled namespaces. WDYT?

Yeah, I considered both options and ended up proposing to make it exclusive since labelling namespaces is straightforward and aligns better with Kubernetes-native practices.

This approach also makes it easier to phase out the CSV method for specifying namespaces over time.

That said, I'm happy with either option—I'll leave it to the maintainers, as you have more insight into how this is being used and where you want to take it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Namespace Selectors to Control Which Namespaces Argo CD Monitors for Changes
2 participants