docs(ingress): use GRPC instead of HTTP2 for AWS #21029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
agaudreault
changed the title
crenshaw-dev
approved these changes
Dec 3, 2024
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify documentation on GRPC ingress with ALB. When HTTP2 is used, the target group will be in a unhealthy state because the HTTP2 health check is downgraded to HTTP1 by argo (Argo-server does not actually support http2, it downgrades everything non-grpc to HTTP1).
When using HTTP2 with Pod Readiness Gates, the pods will never show as "Ready" because the associated target group with the grpc service will never be healthy (due to the invalid health check).
This also matches the default working value in the Helm chart: https://github.com/argoproj/argo-helm/blob/168bc63bd6b65586720ebbcea197dbce123c03f5/charts/argo-cd/values.yaml#L2284-L2288