Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout stuck - persistent update conflict #4073

Open
2 tasks done
risentveber opened this issue Jan 24, 2025 · 0 comments
Open
2 tasks done

Rollout stuck - persistent update conflict #4073

risentveber opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@risentveber
Copy link

risentveber commented Jan 24, 2025

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

Rollout is stuck, due to persistent the object has been modified error during reconciliation.

There is race condition between rollouts informer watch and writeBackToInformer
https://github.com/argoproj/argo-rollouts/blob/v1.7.2/rollout/controller.go#L454.

To Reproduce

  1. controller updates rollout - get version 1
  2. somebody updates rollout - get version 2
  3. informer watches version 2
  4. writeBackToInformer rewrites version 1

Bingo - we have stale data in the informer.

Maybe related to #3316

Expected behavior

not stuck

Screenshots

Image

Version

1.7.2

Logs

only on screenshot


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@risentveber risentveber added the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant