Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept CSV and other files as input values for workflow #12656

Open
panicboat opened this issue Feb 11, 2024 · 5 comments
Open

Accept CSV and other files as input values for workflow #12656

panicboat opened this issue Feb 11, 2024 · 5 comments
Labels
area/spec Changes to the workflow specification. solution/workaround There's a workaround, might not be great, but exists type/feature Feature request

Comments

@panicboat
Copy link
Contributor

Summary

The input value for WorkflowTemplate is a string, but we would also like the CSV file to be an input value.
This may be just our team, but we can work around it by opening the contents of the CSV file and copy/pasting those strings, but mistakes are often made.
Therefore, entering the file format is a safe way to execute the workflow.

Use Cases

It is often used to execute WorkflowTemplate by non-developers.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

@panicboat panicboat added the type/feature Feature request label Feb 11, 2024
@Joibel
Copy link
Member

Joibel commented Feb 11, 2024

With existing workflows you could pass in the CSV as a parameter (either literally or by URI) and then use that parameter in a node which extracts the relevant values for the rest of the workflow. Those extracted parameters would then be available as outputs from that node for other nodes to use.

@Joibel Joibel added the solution/workaround There's a workaround, might not be great, but exists label Feb 11, 2024
@panicboat
Copy link
Contributor Author

Thanks for confirming.
It seems that our organization would like to support input by file, not by CSV string or URI.
Is it difficult to put the WorkflowTemplate in the artifact-repository when it is created?

@agilgur5 agilgur5 added the area/spec Changes to the workflow specification. label Feb 11, 2024
@Joibel
Copy link
Member

Joibel commented Feb 13, 2024

I don't follow what you mean "support input by file". Can you describe what steps you're expecting to follow?

I also don't know what you mean by "Is it difficult to put the WorkflowTemplate in the artifact-repository when it is created?". This seems completely unrelated and also not something anyone would want to do. If this is a separate problem please raise a separate issue.

@panicboat
Copy link
Contributor Author

Sorry I didn't communicate it better.

We would like to have a UI as in HTML.
I want the input to be something that specifies a file and uploads it, since opening a CSV file and copying and pasting strings is prone to errors.

@shippo-eric
Copy link

The ability to upload file object (text or binary) will be very nice! Currently, we need an async process (outside of workflows) to upload a file to s3 bucket, that makes the whole process not user friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spec Changes to the workflow specification. solution/workaround There's a workaround, might not be great, but exists type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants