Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-transient error: <nil> #13881

Open
4 tasks done
black-snow opened this issue Nov 8, 2024 · 6 comments
Open
4 tasks done

Non-transient error: <nil> #13881

black-snow opened this issue Nov 8, 2024 · 6 comments
Labels

Comments

@black-snow
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

I encounter a lot of these:

Non-transient error: <nil>

and sadly there's not much context I can give. Actually, I can give close to nil context. ;)

We run workflows with up to 250 nodes and thousands of concurrent pods. The above log is apparenty just a warning but the nil there seems worrisome. Should I worry?

Sadly, I cannot provide proper steps to reproduce. This ain't very helpful but perhaps someone else is seeing the same or has an immediate idea.

Version(s)

v3.5.12

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

time="2024-11-08T10:02:19.639Z" level=warning msg="Non-transient error: <nil>"

Logs from in your workflow's wait container

N/A
@tooptoop4
Copy link
Contributor

@black-snow provide the controller logs surrounding that line

@isubasinghe
Copy link
Member

This is not really actually an issue, there is a bug where we call IsTransientError on an nil error.

@black-snow
Copy link
Author

Thanks for looking into this. Do you still need the surrounding logs?
Can we get rid of them if they are false positives?

@sarabala1979
Copy link
Member

@black-snow Do you like to contribute? It is a good first issue

@tooptoop4
Copy link
Contributor

@black-snow the surrounding logs can help to know which line to change

@black-snow
Copy link
Author

@sarabala1979 absolutely. Sounds like @isubasinghe already has a notion of where to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants