Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Github actions and workflows #1541

Closed
LegNeato opened this issue Aug 10, 2019 · 8 comments
Closed

Support Github actions and workflows #1541

LegNeato opened this issue Aug 10, 2019 · 8 comments
Labels
type/feature Feature request

Comments

@LegNeato
Copy link

LegNeato commented Aug 10, 2019

FEATURE REQUEST

Soon Github will be publicly releasing Github Actions. If Argo supported the format natively, all public workflows could just work™ in a private Argo install. Also we could use individual actions as steps in custom Argo workflows, leveraging the vast open source community.

This would mean a ton of code and integrations would not have to be implemented by the team or by individual companies. This also means Argo workflows could be migrated to Github Actions with minimal changes (like say, for example, you open source a project and want to open source its CI workflow and run it on Github Actions rather than your internal Argo).

I don't know which repo to add this in as it seems to be a combination of argo, argo events, and argo ci.

Additional context

@LegNeato LegNeato changed the title Support Github actions Support Github actions and workflows Aug 10, 2019
@sarabala1979 sarabala1979 added the type/feature Feature request label Aug 12, 2019
@alexec
Copy link
Contributor

alexec commented Apr 13, 2020

This sounds like #2667 .

@LegNeato
Copy link
Author

Not quite.

This is supporting the action definitions as Argo steps / workflows...not just kicking off Argo workflows similarly to GitHub Actions via webhooks.

For example, I should be able to use any of the workflows/actions in https://github.com/actions/starter-workflows as-is without having to push my own docker container, define Argo yaml, etc.

Workflow definition docs:

https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions

Reference docs:

https://help.github.com/en/actions/reference

@whynowy
Copy link
Member

whynowy commented Apr 16, 2020

This sounds like a narrow use case of "Github notification -> CI workflows"?

@frostebite
Copy link

frostebite commented Apr 28, 2020

This would be absolutely excellent, often I am requesting developers to specifically support their actions running on argo. But this would open the door to the huge ecosystem of github actions. I'm relatively new to argo, but that feels like a game changer.

@alexec
Copy link
Contributor

alexec commented Jul 9, 2020

If I understand correctly, the suggestion in to support an alternative workflow syntax, much like #873. It is unlikely that the core team would implement this due to the lack of utility vs cost.

Perhaps someone from the community might be interseted..

@alexec
Copy link
Contributor

alexec commented Feb 7, 2022

I think this is solved:

https://github.com/marketplace/actions/submit-argo-workflows-from-github

@alexec alexec closed this as completed Feb 7, 2022
@acj
Copy link

acj commented Feb 7, 2022

@alexec That action helps you submit Argo workflows from GHA, but that's been possible since the launch. I think your previous comment captured the feature request here, i.e. the ability to run a GitHub Action natively on Argo, without converting the syntax.

@OneCricketeer
Copy link

Adding my observation.

supported the format natively

There's no standard specification, right? I imagine Argo was developed in parallel to GHA. Asking to change the format is like asking if Airflow tasks could be written in something other than Python. I think that request is a non starter. GHA has the option for a self hosted runner in k8s nowadays...

could use individual actions as steps in custom Argo workflows, leveraging the vast open source community.

Ignoring syntax, I do agree with this sentiment. However, GHA are Javascript first, black-box container second. Argo Workflows are container first, "script" second (at least my use cases). Without looking at GHA source code, doubtful you'd know which is a container (therefore Argo could use as is), or just an npm install away from running from a script action. The first problem that comes to mind, then is how input parameters/output artifacts would be defined without rewriting the code to not be "CI environment specific".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

7 participants