From 371cd00cfb90838b514ce832df18588a1abe7139 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 10:35:08 +0530 Subject: [PATCH 01/26] Enabled the coverage and release on windows --- .github/workflows/main.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index efee77fdb3..f5b198a399 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -16,7 +16,9 @@ jobs: coverage: - runs-on: ubuntu-latest + runs-on: + - ubuntu-latest + - windows-latest steps: - uses: actions/checkout@v2 @@ -86,6 +88,7 @@ jobs: matrix: include: - os: ubuntu-latest + - os: windows-latest # Ignoring Mac until we find a solution to: https://github.com/ethereum/fe/pull/106/checks?check_run_id=1322145918 # - os: macOS-latest steps: @@ -108,6 +111,10 @@ jobs: sudo apt-get install -y libboost-all-dev sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 50 sudo update-alternatives --set g++ "/usr/bin/g++-8" + - name: Install Windows dependencies + if: startsWith(matrix.os, 'win') + uses: MarkusJx/install-boost@v1.0.1 + uses: pavpanchekha/setup-z3@v1.2 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From 9a6fc1a5eadeb8f8b7b6438dbba237be60b5007d Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 10:36:04 +0530 Subject: [PATCH 02/26] commented ubuntu for testing --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f5b198a399..aa524a9e7a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -17,7 +17,7 @@ jobs: coverage: runs-on: - - ubuntu-latest + # - ubuntu-latest - windows-latest steps: @@ -87,7 +87,7 @@ jobs: strategy: matrix: include: - - os: ubuntu-latest + # - os: ubuntu-latest - os: windows-latest # Ignoring Mac until we find a solution to: https://github.com/ethereum/fe/pull/106/checks?check_run_id=1322145918 # - os: macOS-latest From 5969e048d97ed6f00f88fb6cc4f28fe56a7ccd71 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 10:52:48 +0530 Subject: [PATCH 03/26] separated the Z3 and boost stp --- .github/workflows/main.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9490c37638..eef0dfda81 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -111,9 +111,11 @@ jobs: sudo apt-get install -y libboost-all-dev sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 50 sudo update-alternatives --set g++ "/usr/bin/g++-8" - - name: Install Windows dependencies + - name: Install Boost if: startsWith(matrix.os, 'win') uses: MarkusJx/install-boost@v1.0.1 + - name: Install Z3 + if: startsWith(matrix.os, 'win') uses: pavpanchekha/setup-z3@v1.2 - name: Install latest nightly uses: actions-rs/toolchain@v1 From 3000450d196399e17e9738ef7da6aad7f78154fd Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:12:20 +0530 Subject: [PATCH 04/26] added version --- .github/workflows/main.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index eef0dfda81..0fe254a26f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -18,7 +18,6 @@ jobs: runs-on: # - ubuntu-latest - - windows-latest steps: - uses: actions/checkout@v2 @@ -114,6 +113,9 @@ jobs: - name: Install Boost if: startsWith(matrix.os, 'win') uses: MarkusJx/install-boost@v1.0.1 + id: install-boost + with: + boost_version: 1.73.0 - name: Install Z3 if: startsWith(matrix.os, 'win') uses: pavpanchekha/setup-z3@v1.2 From 71059f42f25d80fb689446fb25cb294a8641411f Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:14:44 +0530 Subject: [PATCH 05/26] commented coverage --- .github/workflows/main.yml | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0fe254a26f..074f5832b7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -14,32 +14,32 @@ env: jobs: - coverage: + # coverage: - runs-on: - # - ubuntu-latest + # runs-on: + # - ubuntu-latest - steps: - - uses: actions/checkout@v2 - - name: Cache Rust dependencies - uses: actions/cache@v1.1.2 - with: - # There's a problem with caching serde, hence we exclude it here - path: | - target - !target/**/*serde* - key: ${{ runner.OS }}-build-v2-${{ hashFiles('**/Cargo.lock') }} - - name: Install latest nightly - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: nightly - override: true - - name: coverage with tarpaulin - run: | - cargo install cargo-tarpaulin - make coverage - bash <(curl -s https://codecov.io/bash) + # steps: + # - uses: actions/checkout@v2 + # - name: Cache Rust dependencies + # uses: actions/cache@v1.1.2 + # with: + # # There's a problem with caching serde, hence we exclude it here + # path: | + # target + # !target/**/*serde* + # key: ${{ runner.OS }}-build-v2-${{ hashFiles('**/Cargo.lock') }} + # - name: Install latest nightly + # uses: actions-rs/toolchain@v1 + # with: + # profile: minimal + # toolchain: nightly + # override: true + # - name: coverage with tarpaulin + # run: | + # cargo install cargo-tarpaulin + # make coverage + # bash <(curl -s https://codecov.io/bash) lint: runs-on: ubuntu-latest From df2e4e9170d7a7dbbc9c9fcf9e5b7c2918218e27 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:24:47 +0530 Subject: [PATCH 06/26] removed z3 --- .github/workflows/main.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 074f5832b7..5ce687d0d4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,9 +116,6 @@ jobs: id: install-boost with: boost_version: 1.73.0 - - name: Install Z3 - if: startsWith(matrix.os, 'win') - uses: pavpanchekha/setup-z3@v1.2 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From af5f10f80a26c3df029ebc78e752d1147ee9e82c Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:25:25 +0530 Subject: [PATCH 07/26] commented wasm test --- .github/workflows/main.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5ce687d0d4..d715c5f7ed 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -127,19 +127,19 @@ jobs: - name: Run tests run: cargo test --workspace --features solc-backend --verbose - wasm-test: - runs-on: ubuntu-latest - container: davesque/rust-wasm - steps: - - uses: actions/checkout@v2 - - name: Install latest nightly - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: nightly - override: true - - name: Run WASM tests - run: wasm-pack test --node -- --workspace + # wasm-test: + # runs-on: ubuntu-latest + # container: davesque/rust-wasm + # steps: + # - uses: actions/checkout@v2 + # - name: Install latest nightly + # uses: actions-rs/toolchain@v1 + # with: + # profile: minimal + # toolchain: nightly + # override: true + # - name: Run WASM tests + # run: wasm-pack test --node -- --workspace release: From b15595adfed98ec7897359a5c608cfa9060b49cb Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:26:00 +0530 Subject: [PATCH 08/26] commented lint --- .github/workflows/main.yml | 76 +++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d715c5f7ed..7f864bc670 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -41,44 +41,44 @@ jobs: # make coverage # bash <(curl -s https://codecov.io/bash) - lint: - runs-on: ubuntu-latest - steps: - - name: Install system dependencies - run: | - sudo apt-get install -y libboost-all-dev - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 50 - sudo update-alternatives --set g++ "/usr/bin/g++-8" - - uses: actions/checkout@v2 - - name: Cache Rust dependencies - uses: actions/cache@v1.1.2 - with: - # There's a problem with caching serde, hence we exclude it here - path: | - target - !target/**/*serde* - key: ${{ runner.OS }}-build-v2-${{ hashFiles('**/Cargo.lock') }} - - name: Install latest nightly - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: nightly - override: true - components: rustfmt, clippy - - name: Validate release notes entry - run: ./newsfragments/validate_files.py - - name: Lint with rustfmt - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check - - name: Build - run: cargo build --all-features --verbose - - name: Lint with clippy - uses: actions-rs/cargo@v1 - with: - command: clippy - args: --all-targets --all-features -- -D warnings + # lint: + # runs-on: ubuntu-latest + # steps: + # - name: Install system dependencies + # run: | + # sudo apt-get install -y libboost-all-dev + # sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 50 + # sudo update-alternatives --set g++ "/usr/bin/g++-8" + # - uses: actions/checkout@v2 + # - name: Cache Rust dependencies + # uses: actions/cache@v1.1.2 + # with: + # # There's a problem with caching serde, hence we exclude it here + # path: | + # target + # !target/**/*serde* + # key: ${{ runner.OS }}-build-v2-${{ hashFiles('**/Cargo.lock') }} + # - name: Install latest nightly + # uses: actions-rs/toolchain@v1 + # with: + # profile: minimal + # toolchain: nightly + # override: true + # components: rustfmt, clippy + # - name: Validate release notes entry + # run: ./newsfragments/validate_files.py + # - name: Lint with rustfmt + # uses: actions-rs/cargo@v1 + # with: + # command: fmt + # args: --all -- --check + # - name: Build + # run: cargo build --all-features --verbose + # - name: Lint with clippy + # uses: actions-rs/cargo@v1 + # with: + # command: clippy + # args: --all-targets --all-features -- -D warnings test: # Build & Test runs on all platforms From 2264350d68f084cd952b4ca4497d7ca28dbf6a46 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:29:39 +0530 Subject: [PATCH 09/26] commented extra seteps --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7f864bc670..b5f4aa05c5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -146,7 +146,7 @@ jobs: # Only run this when we push a tag if: startsWith(github.ref, 'refs/tags/') runs-on: ${{ matrix.os }} - needs: [lint, test, wasm-test] + needs: [test] strategy: matrix: include: From a9b880e13ea939d785f3361658026fedbf774dc6 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:51:28 +0530 Subject: [PATCH 10/26] configuring cmake --- .github/workflows/main.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index b5f4aa05c5..d08e752bdc 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,6 +116,11 @@ jobs: id: install-boost with: boost_version: 1.73.0 + - name: Configure CMake + if: startsWith(matrix.os, 'win') + run: cmake . -DCMAKE_BUILD_TYPE=$BUILD_TYPE -B build + env: + BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From 3fc0ae7969f85faeb65bb7ac50842eeb7b282e59 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 11:58:57 +0530 Subject: [PATCH 11/26] setting the env --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d08e752bdc..604fb60535 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -118,7 +118,6 @@ jobs: boost_version: 1.73.0 - name: Configure CMake if: startsWith(matrix.os, 'win') - run: cmake . -DCMAKE_BUILD_TYPE=$BUILD_TYPE -B build env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - name: Install latest nightly From b98d9031361367a4d186a9e992b7d21e2b5d1166 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:06:55 +0530 Subject: [PATCH 12/26] updating the env --- .github/workflows/main.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 604fb60535..a78148e6f8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,10 +116,6 @@ jobs: id: install-boost with: boost_version: 1.73.0 - - name: Configure CMake - if: startsWith(matrix.os, 'win') - env: - BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - name: Install latest nightly uses: actions-rs/toolchain@v1 with: @@ -128,8 +124,13 @@ jobs: override: true - name: Build run: cargo build --all-features --verbose + env: + BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - name: Run tests run: cargo test --workspace --features solc-backend --verbose + env: + BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} + # wasm-test: # runs-on: ubuntu-latest From c8751671a84cfbeb98cdedb0138594b22d1c099d Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:29:34 +0530 Subject: [PATCH 13/26] Fixing the Boost and Cmake different version --- .github/workflows/main.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a78148e6f8..3271a3721f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -126,10 +126,11 @@ jobs: run: cargo build --all-features --verbose env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} + Boost_NO_BOOST_CMAKE: ON - name: Run tests run: cargo test --workspace --features solc-backend --verbose - env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} + Boost_NO_BOOST_CMAKE: ON # wasm-test: From 9e3adea1e35ccaee1f499e52c2691d37b9ab0c02 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:36:41 +0530 Subject: [PATCH 14/26] added missing env --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3271a3721f..d32c7b2f72 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -129,6 +129,7 @@ jobs: Boost_NO_BOOST_CMAKE: ON - name: Run tests run: cargo test --workspace --features solc-backend --verbose + env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} Boost_NO_BOOST_CMAKE: ON From 1237b1c0fa9471798bad697630deb3ff123f1933 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:52:02 +0530 Subject: [PATCH 15/26] downgraded the boost version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d32c7b2f72..d0ebe8b36c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -115,7 +115,7 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.73.0 + boost_version: 1.61.0 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From d4e0ce8913cb68ba212d3b5086348dce5a2481be Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:56:19 +0530 Subject: [PATCH 16/26] downgrading the boost version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d0ebe8b36c..8c919933f2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -115,7 +115,7 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.61.0 + boost_version: 1.65.1 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From 0ecc373a65c7c962d415276a8346e22edb4f7e7c Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 12:59:41 +0530 Subject: [PATCH 17/26] changed to 69 --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8c919933f2..7101f9ac32 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -115,7 +115,7 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.65.1 + boost_version: 1.69.0 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From a87be52ea0cc35bbe579a3a61ef7f9aec6b91c66 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 13:24:09 +0530 Subject: [PATCH 18/26] added Z3 --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7101f9ac32..5a79b979b4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -110,6 +110,9 @@ jobs: sudo apt-get install -y libboost-all-dev sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-8 50 sudo update-alternatives --set g++ "/usr/bin/g++-8" + - name: Install Z3 + if: startsWith(matrix.os, 'win') + uses: pavpanchekha/setup-z3@v1.2 - name: Install Boost if: startsWith(matrix.os, 'win') uses: MarkusJx/install-boost@v1.0.1 From eebfc3e4ce229a5fe92f2d971effe2b8f06a49b0 Mon Sep 17 00:00:00 2001 From: rabans Date: Wed, 20 Jan 2021 13:28:16 +0530 Subject: [PATCH 19/26] updated the version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5a79b979b4..0ed4c697f2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -112,7 +112,7 @@ jobs: sudo update-alternatives --set g++ "/usr/bin/g++-8" - name: Install Z3 if: startsWith(matrix.os, 'win') - uses: pavpanchekha/setup-z3@v1.2 + uses: pavpanchekha/setup-z3@1.2.2 - name: Install Boost if: startsWith(matrix.os, 'win') uses: MarkusJx/install-boost@v1.0.1 From 0e6b4d9efa738b399d2ea919fb705155a0a5fa07 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 12:07:18 +0530 Subject: [PATCH 20/26] trying the vc142 and 1.73.0 --- .github/workflows/main.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0ed4c697f2..bbaadb479d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -118,7 +118,7 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.69.0 + boost_version: 1.73.0 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: @@ -129,7 +129,8 @@ jobs: run: cargo build --all-features --verbose env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - Boost_NO_BOOST_CMAKE: ON + Boost_NO_BOOST_CMAKE: 'ON' + Boost_COMPILER: 'vc142' - name: Run tests run: cargo test --workspace --features solc-backend --verbose env: From 5e980d3f55ab1e51348e52445946766226fe215a Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 12:08:10 +0530 Subject: [PATCH 21/26] adding D before flag --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bbaadb479d..d9c577a253 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -130,6 +130,7 @@ jobs: env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} Boost_NO_BOOST_CMAKE: 'ON' + DBoost_NO_BOOST_CMAKE: 'ON' Boost_COMPILER: 'vc142' - name: Run tests run: cargo test --workspace --features solc-backend --verbose From 58b45b7361530491872f3f8e871350993d7d4ff9 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 12:18:27 +0530 Subject: [PATCH 22/26] checking with 72 --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d9c577a253..311193017f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -118,7 +118,7 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.73.0 + boost_version: 1.72.0 - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From f8f7e7106ec791e36c6019d108a893a76bba39d0 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 15:00:09 +0530 Subject: [PATCH 23/26] added toolset version --- .github/workflows/main.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 311193017f..9ced53727a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -118,7 +118,9 @@ jobs: uses: MarkusJx/install-boost@v1.0.1 id: install-boost with: - boost_version: 1.72.0 + boost_version: 1.73.0 + toolset: msvc14.1 + - name: Install latest nightly uses: actions-rs/toolchain@v1 with: From f59b42b660d4ce2414710db204182dfeca0bf599 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 15:14:18 +0530 Subject: [PATCH 24/26] Setting the boost env to override --- .github/workflows/main.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9ced53727a..94045d2cfc 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -131,9 +131,7 @@ jobs: run: cargo build --all-features --verbose env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} - Boost_NO_BOOST_CMAKE: 'ON' - DBoost_NO_BOOST_CMAKE: 'ON' - Boost_COMPILER: 'vc142' + Boost_COMPILER: override - name: Run tests run: cargo test --workspace --features solc-backend --verbose env: From c733b815155e4a47c8669d83c55e89b36c387513 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 15:16:50 +0530 Subject: [PATCH 25/26] set the boost_ver --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 94045d2cfc..93e7474e18 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -131,6 +131,7 @@ jobs: run: cargo build --all-features --verbose env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} + BOOST_VER: ${{ steps.install-boost.outputs.BOOST_VER}} Boost_COMPILER: override - name: Run tests run: cargo test --workspace --features solc-backend --verbose From 5c874520f2b8d26a0393d34653ec378777e030d4 Mon Sep 17 00:00:00 2001 From: rabans Date: Thu, 21 Jan 2021 15:18:39 +0530 Subject: [PATCH 26/26] removed compiler overrider --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 93e7474e18..5246b8ea1f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -132,7 +132,6 @@ jobs: env: BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }} BOOST_VER: ${{ steps.install-boost.outputs.BOOST_VER}} - Boost_COMPILER: override - name: Run tests run: cargo test --workspace --features solc-backend --verbose env: