New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct HTTP status code on gRPC error #1

Open

veniversum opened this issue May 4, 2018 · 0 comments

Labels

Member

veniversum commented May 4, 2018

Currently, a 500 status code is returned no matter the cause of the error. The API should respond with an appropriate HTTP status code for the error.

An example mapping of gRPC errors -> HTTP status:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/525fb0fc1a7ad064b75050bfc03455508cf0dba5/packages/common/src/grpc-service.js#L50-L135

An example of gRPC response handler:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/525fb0fc1a7ad064b75050bfc03455508cf0dba5/packages/common/src/grpc-service.js#L564

veniversum added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment