From 0ccf865d061ccc6392a24ff09663c65ac52778c3 Mon Sep 17 00:00:00 2001 From: Carl Baillargeon Date: Thu, 26 Oct 2023 03:50:43 -0400 Subject: [PATCH] fix(anta.tests): Fix VerifyVxlanVtep result failure messages (#433) Fix: VerifyVxlanVtep result failure messages --- anta/tests/vxlan.py | 4 ++-- tests/units/anta_tests/test_vxlan.py | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/anta/tests/vxlan.py b/anta/tests/vxlan.py index db0eaa997..c058f30f2 100644 --- a/anta/tests/vxlan.py +++ b/anta/tests/vxlan.py @@ -167,7 +167,7 @@ def test(self) -> None: difference2 = set(vxlan1["vteps"]).difference(set(inputs_vteps)) if difference1: - self.result.is_failure(f"The following VTEP peer(s) are missing from the Vxlan1 interface: {difference1}") + self.result.is_failure(f"The following VTEP peer(s) are missing from the Vxlan1 interface: {sorted(difference1)}") if difference2: - self.result.is_failure(f"Unexpected VTEP peer(s) on Vxlan1 interface: {difference2}") + self.result.is_failure(f"Unexpected VTEP peer(s) on Vxlan1 interface: {sorted(difference2)}") diff --git a/tests/units/anta_tests/test_vxlan.py b/tests/units/anta_tests/test_vxlan.py index c898f4da2..9459a4c21 100644 --- a/tests/units/anta_tests/test_vxlan.py +++ b/tests/units/anta_tests/test_vxlan.py @@ -289,32 +289,32 @@ "test": VerifyVxlanVtep, "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": ["10.1.1.5", "10.1.1.6"]}}}], "inputs": {"vteps": ["10.1.1.5", "10.1.1.6", "10.1.1.7"]}, - "expected": {"result": "failure", "messages": ["The following VTEP peer(s) are missing from the Vxlan1 interface: {'10.1.1.7'}"]}, + "expected": {"result": "failure", "messages": ["The following VTEP peer(s) are missing from the Vxlan1 interface: ['10.1.1.7']"]}, }, { "name": "failure-no-vtep", "test": VerifyVxlanVtep, "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": []}}}], - "inputs": {"vteps": ["10.1.1.5"]}, - "expected": {"result": "failure", "messages": ["The following VTEP peer(s) are missing from the Vxlan1 interface: {'10.1.1.5'}"]}, + "inputs": {"vteps": ["10.1.1.5", "10.1.1.6"]}, + "expected": {"result": "failure", "messages": ["The following VTEP peer(s) are missing from the Vxlan1 interface: ['10.1.1.5', '10.1.1.6']"]}, }, { "name": "failure-no-input-vtep", "test": VerifyVxlanVtep, "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": ["10.1.1.5"]}}}], "inputs": {"vteps": []}, - "expected": {"result": "failure", "messages": ["Unexpected VTEP peer(s) on Vxlan1 interface: {'10.1.1.5'}"]}, + "expected": {"result": "failure", "messages": ["Unexpected VTEP peer(s) on Vxlan1 interface: ['10.1.1.5']"]}, }, { "name": "failure-missmatch", "test": VerifyVxlanVtep, - "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": ["10.1.1.6", "10.1.1.7"]}}}], + "eos_data": [{"vteps": {}, "interfaces": {"Vxlan1": {"vteps": ["10.1.1.6", "10.1.1.7", "10.1.1.8"]}}}], "inputs": {"vteps": ["10.1.1.5", "10.1.1.6"]}, "expected": { "result": "failure", "messages": [ - "The following VTEP peer(s) are missing from the Vxlan1 interface: {'10.1.1.5'}", - "Unexpected VTEP peer(s) on Vxlan1 interface: {'10.1.1.7'}", + "The following VTEP peer(s) are missing from the Vxlan1 interface: ['10.1.1.5']", + "Unexpected VTEP peer(s) on Vxlan1 interface: ['10.1.1.7', '10.1.1.8']", ], }, },