Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added test case to verify Spanning Tree (RPVST) state(stable topology) #791

Merged
merged 7 commits into from
Sep 26, 2024
Merged

feat(anta): Added test case to verify Spanning Tree (RPVST) state(stable topology) #791

merged 7 commits into from
Sep 26, 2024

Conversation

vitthalmagadum
Copy link
Contributor

Description

Verifies the number of changes across all interfaces in the Spanning Tree Protocol (STP) topology is below a threshold.

Expected Results
----------------
* Success: The test will pass if the total number of changes across all interfaces is less than the specified threshold.
* Failure: The test will fail if the total number of changes across all interfaces meets or exceeds the specified threshold,
indicating potential instability in the topology.

Fixes #782

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft August 18, 2024 17:56
MaheshGSLAB
MaheshGSLAB reviewed Aug 20, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
anta/tests/stp.py Outdated Show resolved Hide resolved
tests/units/anta_tests/test_stp.py Show resolved Hide resolved
tests/units/anta_tests/test_stp.py Outdated Show resolved Hide resolved
@vitthalmagadum vitthalmagadum marked this pull request as ready for review August 29, 2024 13:31
MaheshGSLAB
MaheshGSLAB reviewed Aug 29, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
MaheshGSLAB
MaheshGSLAB approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carl-baillargeon
carl-baillargeon reviewed Sep 17, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon reviewed Sep 17, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests with outputs from different configured spanning-tree modes (mstp, rapid-pvst, rstp, none)?

DC1-LEAF1A(config)#spanning-tree mode ?
  backup      Backup port mode
  mstp        Multiple spanning tree protocol
  none        Disable spanning tree
  rapid-pvst  Per VLAN rapid spanning tree protocol
  rstp        Rapid spanning tree protocol

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum
Copy link
Contributor Author

Can you add unit tests with outputs from different configured spanning-tree modes (mstp, rapid-pvst, rstp, none)?

DC1-LEAF1A(config)#spanning-tree mode ?
  backup      Backup port mode
  mstp        Multiple spanning tree protocol
  none        Disable spanning tree
  rapid-pvst  Per VLAN rapid spanning tree protocol
  rstp        Rapid spanning tree protocol

Added unit test for rstp mode.

carl-baillargeon
carl-baillargeon reviewed Sep 25, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
carl-baillargeon
carl-baillargeon reviewed Sep 25, 2024
View reviewed changes
anta/tests/stp.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

carl-baillargeon
carl-baillargeon approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit 6923396 into aristanetworks:main Sep 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: feat(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Test case to verify Spanning Tree (RPVST) state
3 participants
@vitthalmagadum @carl-baillargeon @MaheshGSLAB