Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issue #5

Open
thtTNT opened this issue Nov 23, 2023 · 1 comment
Open

Performance Issue #5

thtTNT opened this issue Nov 23, 2023 · 1 comment

Comments

@thtTNT
Copy link

thtTNT commented Nov 23, 2023

Hi, the project is very useful for me. While it has a performance issue when input goes complex, for example, {A} -> {E,I}, {B,C} -> {D,E,G}, {C,E,H} -> {G,J}, {D} -> {C,J}, {D,H,J} -> {A,B}.

I have done some tests on the application, here are two main reasons for the performance issue:

  1. Latex compiling cost time: Converting latex to HTML is quite slow.
  2. The HTML code generated by latex is quite complex, as the data grows, it consumes lots of memory.

Here are two ways I think which will solve the problem,

  1. Don't use latex, write a small compiler to convert FD to HTML code.
  2. Use a virtual list or pagination, only render limited items on the screen. While, for this method, I can introduce some frameworks like Vue, or only use pure Javascript but more complex.

Which method do you think is better? After your reply, I can work on it and create a PR soon.

@arjo129

@arjo129
Copy link
Owner

arjo129 commented Nov 23, 2023

Hi @thtTNT , thanks for wanting to work on this. Approach 1 seems a lot more sensible. Theres also the question of if its actually render time, or something in the code. A lot of the code has an exponential run time. I kind of wrote this as a hack so 🤷 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants