Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Feed #11

Open
andrzejkrzywda opened this issue Aug 22, 2019 · 4 comments · May be fixed by #43
Open

Activity Feed #11

andrzejkrzywda opened this issue Aug 22, 2019 · 4 comments · May be fixed by #43

Comments

@andrzejkrzywda
Copy link
Member

Once we allow submitting new projects or issues and once people profiles will be somewhat public, we can implement a basic activity feed - what has happened.

This might be a nice educational issue to work on. There is a number of different implementation strategies possible here:

  • use some gems for that
  • built on our own with some after-callbacks
  • make it a read model, separate view component which gets populated after some other places publish events like JuniorProfilePublished or ProjectRegistered or PullRequestAccepted.

I'd go for the event-driven implementation, but this may be too hard for the beginning to many people. So for now, I'm assuming that any implementation is fine.

@n-gb
Copy link

n-gb commented Sep 3, 2019

Reference for future implementers of this issue: here is the link to pretty detailed tutorial to public_activity gem, which can be used to make Activity Feed.

@andrzejkrzywda I agree that event-driven implementation will be too complicated. Maybe it would be easier if this task was divided into a greater number of smaller tasks, so if you'd like to have this strategy specifically - please consider making them :)

@n-gb
Copy link

n-gb commented Sep 3, 2019

@andrzejkrzywda I'm also curious about PullRequestAccepted event - what do you mean by that?

@oxanayoxana
Copy link
Contributor

@andrzejkrzywda have you seen Nadia’s comments?😇

@andrzejkrzywda
Copy link
Member Author

For the first implementation let's go with some gem, as a start and we will see how it goes. public_activity might be a good try. Let's postpone the event-driven ideas for later.

@fstybel fstybel linked a pull request Feb 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants