Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twice slower with dcea02c #67

Open
theirix opened this issue Oct 18, 2016 · 1 comment
Open

Twice slower with dcea02c #67

theirix opened this issue Oct 18, 2016 · 1 comment

Comments

@theirix
Copy link

theirix commented Oct 18, 2016

Hello!

I am using the plugin for a large Redmine installation. Latest commit dcea02c introduced a major slowdown for grouping by issues. Is this patch just a refactoring? Could we safely revert it?

A test report by administrator takes 65 seconds with dcea02c but if I reverse this chunk in a issue_time_entries_for_all_users method then it takes just 27 seconds (surely 27 seconds is not a best result but it is a different story).

It is a strange regression. I think eager_load does not perform well and a simple include with join is faster. Please check attached ruby-prof stack profiles if you need extra information.

@theirix
Copy link
Author

theirix commented Oct 18, 2016

ruby-prof reports: ruby-prof-reports-67.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant